Stowage/browsertrix-crawler
2
0
Fork 0
mirror of https://github.com/webrecorder/browsertrix-crawler.git synced 2025-10-19 14:33:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix typo in QA exclude check, which resulted in all URLs being excluded (#697)

Browse source 
- ensure exclusions now work as expected in replay mode
- add test for using --exclude with replay
This commit is contained in:
Ilya Kreymer 2024-10-07 17:25:36 -07:00 • committed by GitHub
parent 282c47ad66
commit 157ac34d8c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/replaycrawler.ts
View file

@ -256,7 +256,7 @@ export class ReplayCrawler extends Crawler {
}
for (const s of this.excludeRx) {
if (!s.test(url)) {
if (s.test(url)) {
logger.info("Skipping excluded page", { url }, "replay");
return;
}

6
tests/qa_compare.test.js
View file

@ -8,7 +8,7 @@ test("run initial crawl with text and screenshots to prepare for QA", async () =
fs.rmSync("./test-crawls/qa-wr-net", { recursive: true, force: true });
child_process.execSync(
"docker run -v $PWD/test-crawls:/crawls webrecorder/browsertrix-crawler crawl --url https://webrecorder.net/ --url https://webrecorder.net/about --url https://browsertrix.com/ --scopeType page --collection qa-wr-net --text to-warc --screenshot view --generateWACZ",
"docker run -v $PWD/test-crawls:/crawls webrecorder/browsertrix-crawler crawl --url https://webrecorder.net/ --url https://webrecorder.net/about --url https://browsertrix.com/ --url https://webrecorder.net/contact --scopeType page --collection qa-wr-net --text to-warc --screenshot view --generateWACZ",
);
expect(
@ -20,7 +20,7 @@ test("run QA comparison, with write pages to redis", async () => {
fs.rmSync("./test-crawls/qa-wr-net-replay", { recursive: true, force: true });
const child = child_process.exec(
"docker run -p 36380:6379 -v $PWD/test-crawls:/crawls webrecorder/browsertrix-crawler qa --qaSource /crawls/collections/qa-wr-net/qa-wr-net.wacz --collection qa-wr-net-replay --crawlId test --qaDebugImageDiff --writePagesToRedis --debugAccessRedis",
"docker run -p 36380:6379 -v $PWD/test-crawls:/crawls webrecorder/browsertrix-crawler qa --qaSource /crawls/collections/qa-wr-net/qa-wr-net.wacz --collection qa-wr-net-replay --crawlId test --qaDebugImageDiff --writePagesToRedis --debugAccessRedis --exclude contact",
);
// detect crawler exit
@ -54,6 +54,8 @@ test("run QA comparison, with write pages to redis", async () => {
expect(json).toHaveProperty("loadState");
expect(json).toHaveProperty("comparison");
expect(json.title.indexOf("contact") < 0).toBe(true);
expect(json.comparison).toHaveProperty("screenshotMatch");
expect(json.comparison).toHaveProperty("textMatch");
expect(json.comparison).toHaveProperty("resourceCounts");