further fix to stuck on getting new window: (#779)

- set retries back to 3, was set high by mistake
- if will restart, throw exception to restart crawler
- otherwise, attempt to kill browser process that is stalled (appears to
work in testing)
- follow-up to #766

src/util/browser.ts

@@ -396,6 +396,18 @@ export class Browser {
     }
   }
 
+  killBrowser() {
+    // used when main browser process appears to be stalled
+    // puppeteer should still be able to continue, from initial testing
+    // and avoids interrupting crawler when not auto-restarting
+    if (this.browser) {
+      const proc = this.browser.process();
+      if (proc) {
+        proc.kill();
+      }
+    }
+  }
+
   async addInitScript(page: Page, script: string) {
     await page.evaluateOnNewDocument(script);
   }

src/util/worker.ts

@@ -231,9 +231,13 @@ export class PageWorker {
           break;
         }
 
-        if (retry >= 1000000000) {
+        if (retry >= 2) {
           this.crawler.markBrowserCrashed();
-          throw new Error("Unable to load new page, browser needs restart");
+          if (this.crawler.params.restartsOnError) {
+            throw new Error("Unable to load new page, browser needs restart");
+          } else {
+            this.crawler.browser.killBrowser();
+          }
         }
 
         await sleep(0.5);