lang code fixes: (#834)

- validate --lang values, fail immediately with invalid iso-639-1
country code
- ignore --lang value when using profile, print warning that profile
language takes precedence
- fixes #833
This commit is contained in:
Ilya Kreymer 2025-05-12 16:06:29 -07:00 committed by GitHub
parent e39d5a31eb
commit 71de8d6582
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 44 additions and 1 deletions

23
tests/lang-code.test.js Normal file
View file

@ -0,0 +1,23 @@
import { execSync } from "child_process";
test("run crawl with invalid lang", () => {
let status = 0;
try {
execSync(`docker run --rm webrecorder/browsertrix-crawler crawl --url https://webrecorder.net/feed.xml --lang e --limit 1`);
} catch (e) {
status = e.status;
}
expect(status).toBe(17);
});
test("run crawl with valid lang", () => {
let status = 0;
try {
execSync(`docker run --rm webrecorder/browsertrix-crawler crawl --url https://webrecorder.net/feed.xml --lang en --limit 1`);
} catch (e) {
status = e.status;
}
expect(status).toBe(0);
});