From bf6fbe8776fc1e9b212318616e268f121f2f0d35 Mon Sep 17 00:00:00 2001 From: Ilya Kreymer Date: Wed, 2 Apr 2025 09:25:11 -0700 Subject: [PATCH] Remove extra console.log statements (#811) - remove one added in screencaster - also remove others that are outside logging system - bump to 1.5.10 --- package.json | 2 +- src/crawler.ts | 1 - src/replaycrawler.ts | 6 +++++- src/util/screencaster.ts | 2 -- src/util/sitemapper.ts | 8 ++++---- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index 947c71aa..4feaec17 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "browsertrix-crawler", - "version": "1.5.9", + "version": "1.5.10", "main": "browsertrix-crawler", "type": "module", "repository": "https://github.com/webrecorder/browsertrix-crawler", diff --git a/src/crawler.ts b/src/crawler.ts index 7fc12e3f..94a0b0d4 100644 --- a/src/crawler.ts +++ b/src/crawler.ts @@ -2871,7 +2871,6 @@ function getDownloadResponse(req: HTTPRequest) { return resp; } } catch (e) { - console.log(e); // ignore } diff --git a/src/replaycrawler.ts b/src/replaycrawler.ts index 0dbcf66c..75abfc4e 100644 --- a/src/replaycrawler.ts +++ b/src/replaycrawler.ts @@ -285,7 +285,11 @@ export class ReplayCrawler extends Crawler { try { pageData = JSON.parse(page); } catch (e) { - console.log(page, e); + logger.error( + "Error parsing page data", + { data: page, ...formatErr(e) }, + "replay", + ); return; } diff --git a/src/util/screencaster.ts b/src/util/screencaster.ts index eefffd44..74ee7e59 100644 --- a/src/util/screencaster.ts +++ b/src/util/screencaster.ts @@ -195,8 +195,6 @@ class ScreenCaster { this.transport = transport; this.transport.caster = this; - console.log("RATIO", ratio); - if (ratio) { this.maxHeight = this.maxWidth / ratio; } diff --git a/src/util/sitemapper.ts b/src/util/sitemapper.ts index 3ffb40c7..d3c1e627 100644 --- a/src/util/sitemapper.ts +++ b/src/util/sitemapper.ts @@ -304,13 +304,13 @@ export class SitemapReader extends EventEmitter { } } else if (!otherTags) { if (parsingUrl) { - console.warn("text in url, ignoring"); + logger.debug("text in url, ignoring", {}, "sitemap"); } else if (parsingUrlset) { - console.warn("text in urlset, ignoring"); + logger.debug("text in urlset, ignoring", {}, "sitemap"); } else if (parsingSitemap) { - console.warn("text in sitemap, ignoring"); + logger.debug("text in sitemap, ignoring", {}, "sitemap"); } else if (parsingSitemapIndex) { - console.warn("text in sitemapindex, ignoring"); + logger.debug("text in sitemapindex, ignoring", {}, "sitemap"); } } };