From ea9639f0bd67c1cdfe8b32506ded6ac197064581 Mon Sep 17 00:00:00 2001
From: Ilya Kreymer <ikreymer@gmail.com>
Date: Wed, 17 Jan 2024 13:28:14 -0800
Subject: [PATCH] don't exclude 204s

---
 src/util/recorder.ts | 2 +-
 src/util/reqresp.ts  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/util/recorder.ts b/src/util/recorder.ts
index 079acc2c..5b06997f 100644
--- a/src/util/recorder.ts
+++ b/src/util/recorder.ts
@@ -912,7 +912,7 @@ export class Recorder {
   }
 
   async serializeToWARC(reqresp: RequestResponseInfo) {
-    if (reqresp.shouldSkip()) {
+    if (reqresp.shouldSkipSave()) {
       const { url, method, status, payload } = reqresp;
       logNetwork("Skipping request/response", {
         url,
diff --git a/src/util/reqresp.ts b/src/util/reqresp.ts
index 8c0c316a..67870743 100644
--- a/src/util/reqresp.ts
+++ b/src/util/reqresp.ts
@@ -270,12 +270,12 @@ export class RequestResponseInfo {
     return true;
   }
 
-  shouldSkip() {
-    // skip OPTIONS/HEAD responses, and 304, 204 or 206 responses
+  shouldSkipSave() {
+    // skip OPTIONS/HEAD responses, and 304 or 206 responses
     if (
       !this.payload ||
       (this.method && ["OPTIONS", "HEAD"].includes(this.method)) ||
-      [204, 206, 304].includes(this.status)
+      [206, 304].includes(this.status)
     ) {
       return true;
     }