Stowage/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-10-19 15:53:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

admin, reverseproxy: Stop timers if canceled to avoid goroutine leak (#4482)

Browse source
This commit is contained in:
Денис Телюх 2022-01-05 02:14:18 +07:00 • committed by GitHub
parent 249adc1c87
commit 2e46c2ac1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/caddyhttp/reverseproxy/reverseproxy.go
View file

@ -792,10 +792,15 @@ func (lb LoadBalancing) tryAgain(ctx caddy.Context, start time.Time, proxyErr er
}
// otherwise, wait and try the next available host
timer := time.NewTimer(time.Duration(lb.TryInterval))
select {
case <-time.After(time.Duration(lb.TryInterval)):
case <-timer.C:
return true
case <-ctx.Done():
if !timer.Stop() {
// if the timer has been stopped then read from the channel
<-timer.C
}
return false
}
}