From 48bb0365e56666cfe290da483e15a78dc682b0b8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 24 Nov 2025 23:45:22 +0000 Subject: [PATCH] Fix variable capture in ECH rotation goroutine Co-authored-by: mholt <1128849+mholt@users.noreply.github.com> --- modules/caddytls/tls.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/caddytls/tls.go b/modules/caddytls/tls.go index d6324788e..36c1931fd 100644 --- a/modules/caddytls/tls.go +++ b/modules/caddytls/tls.go @@ -428,10 +428,10 @@ func (t *TLS) Start() error { case <-time.After(1 * time.Hour): // ensure old keys are rotated out t.EncryptedClientHello.configsMu.Lock() - err = t.EncryptedClientHello.rotateECHKeys(t.ctx, echLogger, false) + rotateErr := t.EncryptedClientHello.rotateECHKeys(t.ctx, echLogger, false) t.EncryptedClientHello.configsMu.Unlock() - if err != nil { - echLogger.Error("rotating ECH configs failed", zap.Error(err)) + if rotateErr != nil { + echLogger.Error("rotating ECH configs failed", zap.Error(rotateErr)) } case <-t.ctx.Done(): return