mirror of
https://github.com/caddyserver/caddy.git
synced 2025-12-08 06:09:53 +00:00
logging: log_append early option
This commit is contained in:
parent
67a9e0657e
commit
c027ce6ad4
2 changed files with 29 additions and 5 deletions
|
|
@ -15,6 +15,8 @@
|
||||||
package logging
|
package logging
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"strings"
|
||||||
|
|
||||||
"github.com/caddyserver/caddy/v2/caddyconfig/caddyfile"
|
"github.com/caddyserver/caddy/v2/caddyconfig/caddyfile"
|
||||||
"github.com/caddyserver/caddy/v2/caddyconfig/httpcaddyfile"
|
"github.com/caddyserver/caddy/v2/caddyconfig/httpcaddyfile"
|
||||||
"github.com/caddyserver/caddy/v2/modules/caddyhttp"
|
"github.com/caddyserver/caddy/v2/modules/caddyhttp"
|
||||||
|
|
@ -26,7 +28,7 @@ func init() {
|
||||||
|
|
||||||
// parseCaddyfile sets up the log_append handler from Caddyfile tokens. Syntax:
|
// parseCaddyfile sets up the log_append handler from Caddyfile tokens. Syntax:
|
||||||
//
|
//
|
||||||
// log_append [<matcher>] <key> <value>
|
// log_append [<matcher>] [<]<key> <value>
|
||||||
func parseCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
|
func parseCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
|
||||||
handler := new(LogAppend)
|
handler := new(LogAppend)
|
||||||
err := handler.UnmarshalCaddyfile(h.Dispenser)
|
err := handler.UnmarshalCaddyfile(h.Dispenser)
|
||||||
|
|
@ -43,6 +45,10 @@ func (h *LogAppend) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
|
||||||
if !d.NextArg() {
|
if !d.NextArg() {
|
||||||
return d.ArgErr()
|
return d.ArgErr()
|
||||||
}
|
}
|
||||||
|
if strings.HasPrefix(h.Key, "<") && len(h.Key) > 1 {
|
||||||
|
h.Early = true
|
||||||
|
h.Key = h.Key[1:]
|
||||||
|
}
|
||||||
h.Value = d.Val()
|
h.Value = d.Val()
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -42,6 +42,12 @@ type LogAppend struct {
|
||||||
// map, the value of that key will be used. Otherwise
|
// map, the value of that key will be used. Otherwise
|
||||||
// the value will be used as-is as a constant string.
|
// the value will be used as-is as a constant string.
|
||||||
Value string `json:"value,omitempty"`
|
Value string `json:"value,omitempty"`
|
||||||
|
|
||||||
|
// Early, if true, adds the log field before calling
|
||||||
|
// the next handler in the chain. By default, the log
|
||||||
|
// field is added on the way back up the middleware chain,
|
||||||
|
// after all subsequent handlers have completed.
|
||||||
|
Early bool `json:"early,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
// CaddyModule returns the Caddy module information.
|
// CaddyModule returns the Caddy module information.
|
||||||
|
|
@ -53,13 +59,27 @@ func (LogAppend) CaddyModule() caddy.ModuleInfo {
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h LogAppend) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyhttp.Handler) error {
|
func (h LogAppend) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyhttp.Handler) error {
|
||||||
// Run the next handler in the chain first.
|
if h.Early {
|
||||||
|
// Add the log field before calling the next handler
|
||||||
|
h.addLogField(r)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Run the next handler in the chain.
|
||||||
// If an error occurs, we still want to add
|
// If an error occurs, we still want to add
|
||||||
// any extra log fields that we can, so we
|
// any extra log fields that we can, so we
|
||||||
// hold onto the error and return it later.
|
// hold onto the error and return it later.
|
||||||
handlerErr := next.ServeHTTP(w, r)
|
handlerErr := next.ServeHTTP(w, r)
|
||||||
|
|
||||||
// On the way back up the chain, add the extra log field
|
if !h.Early {
|
||||||
|
// Add the log field after the handler completes
|
||||||
|
h.addLogField(r)
|
||||||
|
}
|
||||||
|
|
||||||
|
return handlerErr
|
||||||
|
}
|
||||||
|
|
||||||
|
// addLogField adds the log field to the request's extra log fields.
|
||||||
|
func (h LogAppend) addLogField(r *http.Request) {
|
||||||
ctx := r.Context()
|
ctx := r.Context()
|
||||||
|
|
||||||
vars := ctx.Value(caddyhttp.VarsCtxKey).(map[string]any)
|
vars := ctx.Value(caddyhttp.VarsCtxKey).(map[string]any)
|
||||||
|
|
@ -84,8 +104,6 @@ func (h LogAppend) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyh
|
||||||
// We use zap.Any because it will reflect
|
// We use zap.Any because it will reflect
|
||||||
// to the correct type for us.
|
// to the correct type for us.
|
||||||
extra.Add(zap.Any(h.Key, varValue))
|
extra.Add(zap.Any(h.Key, varValue))
|
||||||
|
|
||||||
return handlerErr
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Interface guards
|
// Interface guards
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue