Stowage/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-10-19 07:43:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

reverseproxy: Improve hostByHashing distribution (#5229)

Browse source 
* If upstreams are all using same host but with different ports
ie:
foobar:4001
foobar:4002
foobar:4003
...
Because fnv-1a has not a good enough avalanche effect
Then the hostByHashing result is not well balanced over
all upstreams

As last byte FNV input tend to affect few bits, the idea is to change
the concatenation order between the key and the upstream strings
So the upstream last byte have more impact on hash diffusion
This commit is contained in:
Alban Lecocq 2022-12-05 19:28:12 +01:00 • committed by GitHub
parent ae77a56ac8
commit d4a7d89f56
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/caddyhttp/reverseproxy/selectionpolicies.go
View file

@ -528,7 +528,7 @@ func hostByHashing(pool []*Upstream, s string) *Upstream {
if !up.Available() {
continue
}
h := hash(s + up.String()) // important to hash key and server together
h := hash(up.String() + s) // important to hash key and server together
if h > highestHash {
highestHash = h
upstream = up