Stowage/clamav
2
0
Fork 0
mirror of https://github.com/Cisco-Talos/clamav.git synced 2025-10-19 10:23:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

CMake: Fix Windows build issue w/ conflicting libraries

Browse source 
At install, the CMake build may fail if it detects the same library
dependency in two locations. This happened for us with the following
error:

  CMake Error at libfreshclam/cmake_install.cmake:157 (file):
    file Multiple conflicting paths found for libcrypto-3-x64.dll:

      C:/Users/clamav_jenkins_svc.TALOS/clam_dependencies/x64/lib/libcrypto-3-x64.dll
      C:/WINDOWS/system32/libcrypto-3-x64.dll
      C:\WINDOWS\system32/libcrypto-3-x64.dll
  Call Stack (most recent call first):
    cmake_install.cmake:96 (include)

This happens when system provided DLL names match exactly with the ones
we provide. ClamAV woudld't prefer that DLL at load time, because it
looks in the EXE directory first. But it does confuse the `file()`
command used to locate build dependencies.

The fix in this commit uses a regex to exclude all libraries found under
C:\Windows
This commit is contained in:
Micah Snyder 2025-02-13 20:07:46 -05:00 • committed by Valerie Snyder
parent 9d72993eba
commit 4d6dc739be
No known key found for this signature in database
GPG key ID: DCBE519BFAF4C517
5 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
clamdtop/CMakeLists.txt
View file

@ -47,6 +47,8 @@ if(WIN32)
UNRESOLVED_DEPENDENCIES_VAR _u_deps
DIRECTORIES
$<TARGET_FILE_DIR:Curses::curses>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
)
foreach(_file ${_r_deps})
string(TOLOWER ${_file} _file_lower)

2
clamsubmit/CMakeLists.txt
View file

@ -57,6 +57,8 @@ if(WIN32)
DIRECTORIES
$<TARGET_FILE_DIR:CURL::libcurl>
$<TARGET_FILE_DIR:JSONC::jsonc>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
)
foreach(_file ${_r_deps})
string(TOLOWER ${_file} _file_lower)

2
libclamav/CMakeLists.txt
View file

@ -495,6 +495,8 @@ if(ENABLE_SHARED_LIB)
$<TARGET_FILE_DIR:PCRE2::pcre2>
$<TARGET_FILE_DIR:LibXml2::LibXml2>
$<TARGET_FILE_DIR:JSONC::jsonc>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
)
foreach(_file ${_r_deps})
string(TOLOWER ${_file} _file_lower)

2
libfreshclam/CMakeLists.txt
View file

@ -83,6 +83,8 @@ if(ENABLE_SHARED_LIB)
$<TARGET_FILE_DIR:CURL::libcurl>
$<TARGET_FILE_DIR:OpenSSL::SSL>
$<TARGET_FILE_DIR:OpenSSL::Crypto>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
)
foreach(_file ${_r_deps})
string(TOLOWER ${_file} _file_lower)

4
unit_tests/CMakeLists.txt
View file

@ -441,6 +441,8 @@ if(WIN32)
$<TARGET_FILE_DIR:LibXml2::LibXml2>
$<TARGET_FILE_DIR:CURL::libcurl>
$<TARGET_FILE_DIR:JSONC::jsonc>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
CONFLICTING_DEPENDENCIES_PREFIX CTEST_CONFLICTING_DEPENDENCIES
)
foreach(_file ${_r_deps})
@ -496,6 +498,8 @@ if(WIN32)
$<TARGET_FILE_DIR:PCRE2::pcre2>
$<TARGET_FILE_DIR:LibXml2::LibXml2>
$<TARGET_FILE_DIR:JSONC::jsonc>
POST_EXCLUDE_REGEXES
"[cC]:[\\/][wW][iI][nN][dD][oO][wW][sS]"
CONFLICTING_DEPENDENCIES_PREFIX CTEST_CONFLICTING_DEPENDENCIES
)
foreach(_file ${_r_deps})