clamav/unit_tests/check_regex.c

/*
 *  Unit tests for regular expression processing.
 *
 *  Copyright (C) 2008 Sourcefire, Inc.
 *
 *  Authors: Török Edvin
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License version 2 as
 *  published by the Free Software Foundation.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 *  MA 02110-1301, USA.
 */
#if HAVE_CONFIG_H
#include "clamav-config.h"
#endif

#include <stdio.h>
#include <stdlib.h>
#include <limits.h>
#include <string.h>
#include <check.h>

#include <openssl/ssl.h>
#include <openssl/err.h>
#include "libclamav/crypto.h"

#include "../libclamav/clamav.h"
#include "../libclamav/others.h"
#include "../libclamav/mbox.h"
#include "../libclamav/message.h"
#include "../libclamav/htmlnorm.h"
#include "../libclamav/phishcheck.h"
#include "../libclamav/regex_suffix.h"
#include "../libclamav/regex_list.h"
#include "../libclamav/phish_domaincheck_db.h"
#include "../libclamav/phish_whitelist.h"
#include "checks.h"

static size_t cb_called = 0;

static int cb_fail(void *cbdata, const char *suffix, size_t len, const struct regex_list *regex)
{
	fail("this pattern is not supposed to have a suffix");
	return -1;
}

static int cb_expect_single(void *cbdata, const char *suffix, size_t len, const struct regex_list *regex)
{
	const char *expected = cbdata;
	cb_called++;
	fail_unless_fmt(suffix && strcmp(suffix, expected) == 0,
			"suffix mismatch, was: %s, expected: %s\n", suffix, expected);
	return 0;
}

static struct regex_list regex;
START_TEST (empty)
{
	const char pattern[] = "";
	int rc;
	regex_t *preg;

	errmsg_expected();
	preg = malloc(sizeof(*regex.preg));
	fail_unless(!!preg, "malloc");
	rc = cli_regex2suffix(pattern, preg, cb_fail, NULL);
	free(preg);
	fail_unless(rc == REG_EMPTY, "empty pattern");
	fail_unless(cb_called == 0, "callback shouldn't be called");
}
END_TEST

START_TEST (one)
{
	char pattern[] = "a";
	int rc;
	regex_t *preg;

	preg = malloc(sizeof(*regex.preg));
	fail_unless(!!preg, "malloc");
	rc = cli_regex2suffix(pattern, preg, cb_expect_single, pattern);
	fail_unless(rc == 0, "single character pattern");
	cli_regfree(preg);
	free(preg);
	fail_unless(cb_called == 1, "callback should be called once");
}
END_TEST


static const char *ex1[] =
 {"com|de","moc","ed",NULL};
static const char *ex2[] =
 {"xd|(a|e)bc","dx","cba","cbe",NULL};

static const char **tests[] = {
	ex1,
	ex2
};


static int cb_expect_multi(void *cbdata, const char *suffix, size_t len, const struct regex_list *r)
{
	const char **exp = cbdata;
	fail_unless(!!exp, "expected data");
	exp++;
	fail_unless_fmt(!!*exp, "expected no suffix, got: %s\n",suffix);
	fail_unless_fmt(!!exp[cb_called], "expected less suffixes, but already got: %d\n", cb_called);
	fail_unless_fmt(strcmp(exp[cb_called], suffix) == 0,
			"suffix mismatch, was: %s, expected: %s\n",suffix, exp[cb_called]);
	fail_unless_fmt(strlen(suffix) == len, "incorrect suffix len, expected: %d, got: %d\n", strlen(suffix), len);
	cb_called++;
	return 0;
}

#ifdef CHECK_HAVE_LOOPS
START_TEST (test_suffix)
{
	int rc;
	regex_t *preg;
	const char *pattern = tests[_i][0];
	size_t n=0;
	const char **p=tests[_i];

	fail_unless(!!pattern, "test pattern");
	preg = malloc(sizeof(*regex.preg));
	fail_unless(!!preg, "malloc");
	rc = cli_regex2suffix(pattern, preg, cb_expect_multi, tests[_i]);
	fail_unless(rc == 0, "single character pattern");
	cli_regfree(preg);
	free(preg);
	p++;
	while(*p++) n++;
	fail_unless_fmt(cb_called == n,
			"suffix number mismatch, expected: %d, was: %d\n", n, cb_called);
}
END_TEST
#endif /* CHECK_HAVE_LOOPS */

static void setup(void)
{
	cb_called = 0;
}

static void teardown(void)
{
}

static struct regex_matcher matcher;

static void rsetup(void)
{
	int rc;
#ifdef USE_MPOOL
	matcher.mempool = mpool_create();
#endif
	rc = init_regex_list(&matcher, 1);
	fail_unless(rc == 0, "init_regex_list");
}

static void rteardown(void)
{
	regex_list_done(&matcher);
#ifdef USE_MPOOL
	mpool_destroy(matcher.mempool);
#endif
}

static const struct rtest {
	const char *pattern;/* NULL if not meant for whitelist testing */
	const char *realurl;
	const char *displayurl;
	int result;/* 0 - phish, 1 - whitelisted, 2 - clean, 
		      3 - blacklisted if 2nd db is loaded,
		      4 - invalid regex*/
} rtests[] = {
        {NULL,"http://fake.example.com", "http://foo@key.com/", 0},
	{NULL,"http://fake.example.com", "foo.example.com@key.com", 0},
	{NULL,"http://fake.example.com", "foo@key.com", 2},
	{NULL,"http://fake.example.com","&#61;&#61;&#61;&#61;&#61;key.com",0},
	{NULL,"http://key.com","&#61;&#61;&#61;&#61;&#61;key.com",2},
	{NULL," http://key.com","&#61;&#61;&#61;&#61;&#61;key.com",2},
	{NULL,"http://key.com@fake.example.com","key.com",0},
	{NULL," http://key.com@fake.example.com","key.com",0},
	{NULL," http://key.com@fake.example.com ","key.com",0},
	/* entry taken from .wdb with a / appended */
	{".+\\.ebayrtm\\.com([/?].*)?:.+\\.ebay\\.(de|com|co\\.uk)([/?].*)?/",
		"http://srx.main.ebayrtm.com",
		"pages.ebay.de",
		1 /* should be whitelisted */},
	{".+\\.ebayrtm\\.com([/?].*)?:.+\\.ebay\\.(de|com|co\\.uk)([/?].*)?/",
		"http://srx.main.ebayrtm.com.evil.example.com",
		"pages.ebay.de",
		0},
	{".+\\.ebayrtm\\.com([/?].*)?:.+\\.ebay\\.(de|com|co\\.uk)([/?].*)?/",
		"www.www.ebayrtm.com?somecgi",
		"www.ebay.com/something",1},
	{NULL,
		"http://key.com","go to key.com",2
	},
	{":.+\\.paypal\\.(com|de|fr|it)([/?].*)?:.+\\.ebay\\.(at|be|ca|ch|co\\.uk|de|es|fr|ie|in|it|nl|ph|pl|com(\\.(au|cn|hk|my|sg))?)([/?].*)?/",
	    "http://www.paypal.com", "pics.ebay.com", 1},
	{NULL, "http://somefakeurl.example.com","someotherdomain-key.com",2},
	{NULL, "http://somefakeurl.example.com","someotherdomain.key.com",0},
	{NULL, "http://1.test.example.com/something","test",3},
	{NULL, "http://1.test.example.com/2","test",3},
	{NULL, "http://user@1.test.example.com/2","test",3},
	{NULL, "http://user@1.test.example.com/2/test","test",3},
	{NULL, "http://user@1.test.example.com/","test",3},
	{NULL, "http://x.exe","http:///x.exe",2},
	{".+\\.ebayrtm\\.com([/?].*)?:[^.]+\\.ebay\\.(de|com|co\\.uk)/",
		"http://srx.main.ebayrtm.com",
		"pages.ebay.de",
		1 /* should be whitelisted */},
	{".+\\.ebayrtm\\.com([/?].*)?:.+[r-t]\\.ebay\\.(de|com|co\\.uk)/",
		"http://srx.main.ebayrtm.com",
		"pages.ebay.de",
		1 /* should be whitelisted */},
	{".+\\.ebayrtm\\.com([/?].*)?:.+[r-t]\\.ebay\\.(de|com|co\\.uk)/",
		"http://srx.main.ebayrtm.com",
		"pages.ebay.de",
		1 /* should be whitelisted */},
	{"[t-","","",4},
	{NULL,"http://co.uk","http:// co.uk",2},
	{NULL,"http://co.uk","     ",2},
	{NULL,"127.0.0.1","pages.ebay.de",2},
	{".+\\.ebayrtm\\.com([/?].*)?:.+\\.ebay\\.(de|com|co\\.uk)([/?].*)?/",
		"http://pages.ebay.de@fake.example.com","pages.ebay.de",0},
	{NULL,"http://key.com","https://key.com",0},
	{NULL,"http://key.com%00fake.example.com","https://key.com",0},
	{NULL,"http://key.com.example.com","key.com.invalid",0}
};

#ifdef CHECK_HAVE_LOOPS
START_TEST (regex_list_match_test)
{
	const char *info;
	const struct rtest *rtest = &rtests[_i];
	char *pattern, *realurl;
	int rc;

	if(!rtest->pattern) {
		fail_unless(rtest->result != 1,
				"whitelist test must have pattern set");
		/* this test entry is not meant for whitelist testing */
		return;
	}

	fail_unless(rtest->result == 0 || rtest->result == 1 || rtest->result==4,
			"whitelist test result must be either 0 or 1 or 4");
	pattern = cli_strdup(rtest->pattern);
	fail_unless(!!pattern, "cli_strdup");

	rc = regex_list_add_pattern(&matcher, pattern);
	if(rtest->result == 4) {
		fail_unless(rc, "regex_list_add_pattern should return error");
		free(pattern);
		return;
	} else
		fail_unless(rc == 0,"regex_list_add_pattern");
	free(pattern);

	matcher.list_loaded = 1;

	rc = cli_build_regex_list(&matcher);
	fail_unless(rc == 0,"cli_build_regex_list");

	fail_unless(is_regex_ok(&matcher),"is_regex_ok");

	realurl = cli_strdup(rtest->realurl);
	rc = regex_list_match(&matcher, realurl, rtest->displayurl, NULL, 1, &info, 1);
	fail_unless(rc == rtest->result,"regex_list_match");
	/* regex_list_match is not supposed to modify realurl in this case */
	fail_unless(!strcmp(realurl, rtest->realurl), "realurl altered");
	free(realurl);
}
END_TEST
#endif /* CHECK_HAVE_LOOPS */

static struct cl_engine *engine;
static int loaded_2 = 0;

static void psetup_impl(int load2)
{
	FILE *f;
	int rc;
	unsigned signo=0;

	engine = cl_engine_new();
	fail_unless(!!engine , "cl_engine_new");

	phishing_init(engine);
	fail_unless(!!engine->phishcheck, "phishing_init");

	rc = init_domainlist(engine);
	fail_unless(rc == 0,"init_domainlist");

	f = fdopen(open_testfile("input/daily.pdb"),"r");
	fail_unless(!!f, "fopen daily.pdb");

	rc = load_regex_matcher(engine, engine->domainlist_matcher,  f, &signo, 0, 0, NULL, 1);
	fail_unless(rc == 0, "load_regex_matcher");
	fclose(f);

	fail_unless_fmt(signo == 201, "Incorrect number of signatures: %u, expected %u", signo, 201);

	if(load2) {
		f = fdopen(open_testfile("input/daily.gdb"),"r");
		fail_unless(!!f, "fopen daily.gdb");

		signo = 0;
		rc = load_regex_matcher(engine, engine->domainlist_matcher,  f, &signo, 0, 0, NULL, 1);
		fail_unless(rc == 0, "load_regex_matcher");
		fclose(f);

		fail_unless_fmt(signo == 4, "Incorrect number of signatures: %u, expected %u", signo, 4);
	}
	loaded_2 = load2;

	rc = init_whitelist(engine);
	fail_unless(rc == 0,"init_whitelist");

	f = fdopen(open_testfile("input/daily.wdb"),"r");
	signo = 0;
	rc = load_regex_matcher(engine, engine->whitelist_matcher, f, &signo, 0, 1, NULL, 1);
	fail_unless(rc == 0,"load_regex_matcher");
	fclose(f);

	fail_unless_fmt(signo == 31, "Incorrect number of signatures: %u, expected %u", signo, 31);

	rc = cli_build_regex_list(engine->whitelist_matcher);
	fail_unless(rc == 0,"cli_build_regex_list");

	rc = cli_build_regex_list(engine->domainlist_matcher);
	fail_unless(rc == 0,"cli_build_regex_list");

	fail_unless(is_regex_ok(engine->whitelist_matcher),"is_regex_ok");
	fail_unless(is_regex_ok(engine->domainlist_matcher),"is_regex_ok");
}

static void psetup(void)
{
	psetup_impl(0);
}

static void psetup2(void)
{
	psetup_impl(1);
}


static void pteardown(void)
{
	if(engine) {
		cl_engine_free(engine);
	}
	engine = NULL;
}


static void do_phishing_test(const struct rtest *rtest)
{
	char *realurl;
	cli_ctx ctx;
	const char *virname = NULL;
	tag_arguments_t hrefs;
	int rc;

	memset(&ctx, 0, sizeof(ctx));

	realurl = cli_strdup(rtest->realurl);
	fail_unless(!!realurl, "cli_strdup");

	hrefs.count = 1;
	hrefs.value = cli_malloc(sizeof(*hrefs.value));
	fail_unless(!!hrefs.value, "cli_malloc");
	hrefs.value[0] = (unsigned char*)realurl;
	hrefs.contents = cli_malloc(sizeof(*hrefs.contents));
	fail_unless(!!hrefs.contents, "cli_malloc");
	hrefs.tag = cli_malloc(sizeof(*hrefs.tag));
	fail_unless(!!hrefs.tag, "cli_malloc");
	hrefs.tag[0] = (unsigned char*)cli_strdup("href");
	hrefs.contents[0] = (unsigned char*)cli_strdup(rtest->displayurl);

	ctx.engine = engine;
	ctx.virname = &virname;

	rc = phishingScan(&ctx, &hrefs);

	html_tag_arg_free(&hrefs);
	fail_unless(rc == CL_CLEAN,"phishingScan");
	switch(rtest->result) {
		case 0:
			fail_unless_fmt(ctx.found_possibly_unwanted,
					"this should be phishing, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 1:
			fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be whitelisted, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 2:
			fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be clean, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 3:
			if(!loaded_2)
				fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be clean, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			else {
				fail_unless_fmt(ctx.found_possibly_unwanted,
					"this should be blacklisted, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
				if (*ctx.virname)
				    fail_unless_fmt(!strstr((const char*)*ctx.virname,"Blacklisted"),
						    "should be blacklisted, but is: %s\n", ctx.virname);
			}
			break;
	}
}

static void do_phishing_test_allscan(const struct rtest *rtest)
{
	char *realurl;
	cli_ctx ctx;
	const char *virname = NULL;
	tag_arguments_t hrefs;
	int rc;

	memset(&ctx, 0, sizeof(ctx));

	realurl = cli_strdup(rtest->realurl);
	fail_unless(!!realurl, "cli_strdup");

	hrefs.count = 1;
	hrefs.value = cli_malloc(sizeof(*hrefs.value));
	fail_unless(!!hrefs.value, "cli_malloc");
	hrefs.value[0] = (unsigned char*)realurl;
	hrefs.contents = cli_malloc(sizeof(*hrefs.contents));
	fail_unless(!!hrefs.contents, "cli_malloc");
	hrefs.tag = cli_malloc(sizeof(*hrefs.tag));
	fail_unless(!!hrefs.tag, "cli_malloc");
	hrefs.tag[0] = (unsigned char*)cli_strdup("href");
	hrefs.contents[0] = (unsigned char*)cli_strdup(rtest->displayurl);

	ctx.engine = engine;
	ctx.virname = &virname;
	ctx.options |= CL_SCAN_ALLMATCHES;

	rc = phishingScan(&ctx, &hrefs);

	html_tag_arg_free(&hrefs);
	fail_unless(rc == CL_CLEAN,"phishingScan");
	switch(rtest->result) {
		case 0:
			fail_unless_fmt(ctx.found_possibly_unwanted,
					"this should be phishing, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 1:
			fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be whitelisted, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 2:
			fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be clean, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			break;
		case 3:
			if(!loaded_2)
				fail_unless_fmt(!ctx.found_possibly_unwanted,
					"this should be clean, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
			else {
				fail_unless_fmt(ctx.found_possibly_unwanted,
					"this should be blacklisted, realURL: %s, displayURL: %s",
					rtest->realurl, rtest->displayurl);
				if (*ctx.virname)
				    fail_unless_fmt(!strstr((const char*)*ctx.virname,"Blacklisted"),
						    "should be blacklisted, but is: %s\n", ctx.virname);
			}
			break;
	}
	if (ctx.num_viruses)
	    free((void *)ctx.virname);
}

#ifdef CHECK_HAVE_LOOPS
START_TEST (phishingScan_test)
{
	do_phishing_test(&rtests[_i]);
}
END_TEST

START_TEST (phishingScan_test_allscan)
{
	do_phishing_test_allscan(&rtests[_i]);
}
END_TEST
#endif

#ifdef CHECK_HAVE_LOOPS
static struct uc {
    const char *in;
    const char *host;
    const char *path;
} uc[] = {
    {":example/%25%32%35", "example/", "%25"},
    {":example/%25%32%35%25%32%35", "example/", "%25%25"},
    {":example/abc%25%32%35asd", "example/", "abc%25asd"},
    {":www.example.com/","www.example.com/",""},
    {":%31%32%37%2e%30%2e%30%2e%31/%2E%73%65%63%75%72%65/%77%77%77%2e%65%78%61%6d%70%6c%65%2e%63%6f%6d/", 
	"127.0.0.1/",".secure/www.example.com/"},
    {":127.0.0.1/uploads/%20%20%20%20/.verify/.blah=abcd-ef=gh/",
	"127.0.0.1/","uploads/%20%20%20%20/.verify/.blah=abcd-ef=gh/"},
    {"http://example%23.com/%61%40%62%252B",
	"example%23.com/", "a@b+"},
    {"http://example.com/blah/..","example.com/",""},
    {"http://example.com/blah/../x","example.com/","x"},
    {"http://example.com/./a","example.com/","a"}
};

START_TEST (test_url_canon)
{
    char urlbuff[1024+3];
    char *host = NULL;
    const char *path = NULL;
    size_t host_len, path_len;
    struct uc *u = &uc[_i];

    cli_url_canon(u->in, strlen(u->in), urlbuff, sizeof(urlbuff), &host, &host_len, &path, &path_len);
    fail_unless(!!host && !!path, "null results\n");
    fail_unless_fmt(!strcmp(u->host, host), "host incorrect: %s\n", host);
    fail_unless_fmt(!strcmp(u->path, path), "path incorrect: %s\n", path);
}
END_TEST

static struct regex_test {
    const char *regex;
    const char *text;
    int match;
} rg[] = {
    {"\\.exe$", "test.exe", 1},
    {"\\.exe$", "test.eXe", 0},
    {"(?i)\\.exe$", "test.exe", 1},
    {"(?i)\\.exe$", "test.eXe", 1}
};

START_TEST (test_regexes)
{
    regex_t reg;
    struct regex_test *tst = &rg[_i];
    int match;

    fail_unless(cli_regcomp(&reg, tst->regex, REG_EXTENDED | REG_NOSUB) == 0, "cli_regcomp");
    match = (cli_regexec(&reg, tst->text, 0, NULL, 0) == REG_NOMATCH) ? 0 : 1;
    fail_unless_fmt(match == tst->match, "cli_regexec failed for %s and %s\n", tst->regex, tst->text);
    cli_regfree(&reg);
}
END_TEST
#endif

START_TEST(phishing_fake_test)
{
	char buf[4096];
	FILE *f = fdopen(open_testfile("input/daily.pdb"),"r");
	fail_unless(!!f,"fopen daily.pdb");
	while(fgets(buf, sizeof(buf), f)) {
		struct rtest rtest;
		const char *pdb = strchr(buf,':');
		fail_unless(!!pdb, "missing : in pdb");
		rtest.realurl = pdb;
		rtest.displayurl = pdb;
		rtest.result = 2;
		do_phishing_test(&rtest);
		rtest.realurl = "http://fake.example.com";
		rtest.result = 0;
		do_phishing_test(&rtest);
	}
	fclose(f);
}
END_TEST

START_TEST(phishing_fake_test_allscan)
{
	char buf[4096];
	FILE *f = fdopen(open_testfile("input/daily.pdb"),"r");
	fail_unless(!!f,"fopen daily.pdb");
	while(fgets(buf, sizeof(buf), f)) {
		struct rtest rtest;
		const char *pdb = strchr(buf,':');
		fail_unless(!!pdb, "missing : in pdb");
		rtest.realurl = pdb;
		rtest.displayurl = pdb;
		rtest.result = 2;
		do_phishing_test_allscan(&rtest);
		rtest.realurl = "http://fake.example.com";
		rtest.result = 0;
		do_phishing_test_allscan(&rtest);
	}
	fclose(f);
}
END_TEST

Suite *test_regex_suite(void)
{
	Suite *s = suite_create("regex");
	TCase *tc_api, *tc_matching, *tc_phish, *tc_phish2, *tc_regex;

	tc_api = tcase_create("cli_regex2suffix");
	suite_add_tcase(s, tc_api);
	tcase_add_checked_fixture (tc_api, setup, teardown);
	tcase_add_test(tc_api, empty);
	tcase_add_test(tc_api, one);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_api, test_suffix, 0, sizeof(tests)/sizeof(tests[0]));
#endif
	tc_matching = tcase_create("regex_list");
	suite_add_tcase(s, tc_matching);
	tcase_add_checked_fixture (tc_matching, rsetup, rteardown);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_matching, regex_list_match_test, 0, sizeof(rtests)/sizeof(rtests[0]));
#endif
	tc_phish = tcase_create("phishingScan");
	suite_add_tcase(s, tc_phish);
	tcase_add_unchecked_fixture(tc_phish, psetup, pteardown);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_phish, phishingScan_test, 0, sizeof(rtests)/sizeof(rtests[0]));
	tcase_add_loop_test(tc_phish, phishingScan_test_allscan, 0, sizeof(rtests)/sizeof(rtests[0]));
#endif
	tcase_add_test(tc_phish, phishing_fake_test);
	tcase_add_test(tc_phish, phishing_fake_test_allscan);

	tc_phish2 = tcase_create("phishingScan with 2 dbs");
	suite_add_tcase(s, tc_phish2);
	tcase_add_unchecked_fixture(tc_phish2, psetup2, pteardown);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_phish2, phishingScan_test, 0, sizeof(rtests)/sizeof(rtests[0]));
	tcase_add_loop_test(tc_phish2, phishingScan_test_allscan, 0, sizeof(rtests)/sizeof(rtests[0]));
#endif
	tcase_add_test(tc_phish2, phishing_fake_test);
	tcase_add_test(tc_phish2, phishing_fake_test_allscan);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_phish, test_url_canon, 0, sizeof(uc)/sizeof(uc[0]));
#endif

	tc_regex = tcase_create("cli_regcomp/execute");
	suite_add_tcase(s, tc_regex);
#ifdef CHECK_HAVE_LOOPS
	tcase_add_loop_test(tc_regex, test_regexes, 0, sizeof(rg)/sizeof(rg[0]));
#endif
	return s;
}