mirror of
https://github.com/Cisco-Talos/clamav.git
synced 2025-10-19 10:23:17 +00:00
9e20cdf6ea
This patch adds experimental-quality CMake build tooling. The libmspack build required a modification to use "" instead of <> for header #includes. This will hopefully be included in the libmspack upstream project when adding CMake build tooling to libmspack. Removed use of libltdl when using CMake. Flex & Bison are now required to build. If -DMAINTAINER_MODE, then GPERF is also required, though it currently doesn't actually do anything. TODO! I found that the autotools build system was generating the lexer output but not actually compiling it, instead using previously generated (and manually renamed) lexer c source. As a consequence, changes to the .l and .y files weren't making it into the build. To resolve this, I removed generated flex/bison files and fixed the tooling to use the freshly generated files. Flex and bison are now required build tools. On Windows, this adds a dependency on the winflexbison package, which can be obtained using Chocolatey or may be manually installed. CMake tooling only has partial support for building with external LLVM library, and no support for the internal LLVM (to be removed in the future). I.e. The CMake build currently only supports the bytecode interpreter. Many files used include paths relative to the top source directory or relative to the current project, rather than relative to each build target. Modern CMake support requires including internal dependency headers the same way you would external dependency headers (albeit with "" instead of <>). This meant correcting all header includes to be relative to the build targets and not relative to the workspace. For example, ... ```c include "../libclamav/clamav.h" include "clamd/clamd_others.h" ``` ... becomes: ```c // libclamav include "clamav.h" // clamd include "clamd_others.h" ``` Fixes header name conflicts by renaming a few of the files. Converted the "shared" code into a static library, which depends on libclamav. The ironically named "shared" static library provides features common to the ClamAV apps which are not required in libclamav itself and are not intended for use by downstream projects. This change was required for correct modern CMake practices but was also required to use the automake "subdir-objects" option. This eliminates warnings when running autoreconf which, in the next version of autoconf & automake are likely to break the build. libclamav used to build in multiple stages where an earlier stage is a static library containing utils required by the "shared" code. Linking clamdscan and clamdtop with this libclamav utils static lib allowed these two apps to function without libclamav. While this is nice in theory, the practical gains are minimal and it complicates the build system. As such, the autotools and CMake tooling was simplified for improved maintainability and this feature was thrown out. clamdtop and clamdscan now require libclamav to function. Removed the nopthreads version of the autotools libclamav_internal_utils static library and added pthread linking to a couple apps that may have issues building on some platforms without it, with the intention of removing needless complexity from the source. Kept the regular version of libclamav_internal_utils.la though it is no longer used anywhere but in libclamav. Added an experimental doxygen build option which attempts to build clamav.h and libfreshclam doxygen html docs. The CMake build tooling also may build the example program(s), which isn't a feature in the Autotools build system. Changed C standard to C90+ due to inline linking issues with socket.h when linking libfreshclam.so on Linux. Generate common.rc for win32. Fix tabs/spaces in shared Makefile.am, and remove vestigial ifndef from misc.c. Add CMake files to the automake dist, so users can try the new CMake tooling w/out having to build from a git clone. clamonacc changes: - Renamed FANOTIFY macro to HAVE_SYS_FANOTIFY_H to better match other similar macros. - Added a new clamav-clamonacc.service systemd unit file, based on the work of ChadDevOps & Aaron Brighton. - Added missing clamonacc man page. Updates to clamdscan man page, add missing options. Remove vestigial CL_NOLIBCLAMAV definitions (all apps now use libclamav). Rename Windows mspack.dll to libmspack.dll so all ClamAV-built libraries have the lib-prefix with Visual Studio as with CMake.
105 lines
3.6 KiB
CMake
105 lines
3.6 KiB
CMake
#
|
|
# Check if file descriptor passing is supported
|
|
# Derived from work submitted by Richard Lyons <frob-clamav@webcentral.com.au>
|
|
#
|
|
|
|
GET_FILENAME_COMPONENT(_selfdir_CheckFDPassing
|
|
"${CMAKE_CURRENT_LIST_FILE}" PATH)
|
|
|
|
include(CheckSymbolExists)
|
|
check_symbol_exists(recvmsg "sys/socket.h" HAVE_RECVMSG)
|
|
check_symbol_exists(sendmsg "sys/socket.h" HAVE_SENDMSG)
|
|
|
|
# Extra -D Compile Definitions for check_c_source_compiles()
|
|
set(CMAKE_REQUIRED_DEFINITIONS "")
|
|
if(HAVE_SYS_TYPES_H)
|
|
set(CMAKE_REQUIRED_DEFINITIONS "${CMAKE_REQUIRED_DEFINITIONS};-DHAVE_SYS_TYPES_H=1")
|
|
endif()
|
|
if(HAVE_SYS_UIO_H)
|
|
set(CMAKE_REQUIRED_DEFINITIONS "${CMAKE_REQUIRED_DEFINITIONS};-DHAVE_SYS_UIO_H=1")
|
|
endif()
|
|
|
|
# Check for msg_control field in struct msghdr
|
|
check_c_source_compiles(
|
|
"
|
|
#define _XOPEN_SOURCE 500
|
|
#ifdef HAVE_SYS_TYPES_H
|
|
# include <sys/types.h>
|
|
#endif
|
|
#include <sys/socket.h>
|
|
#ifdef HAVE_SYS_UIO_H
|
|
# include <sys/uio.h>
|
|
#endif
|
|
|
|
int main(void) {
|
|
#ifdef msg_control
|
|
# error msg_control defined
|
|
#endif
|
|
|
|
struct msghdr m;
|
|
m.msg_control = 0;
|
|
return 0;
|
|
}
|
|
"
|
|
HAVE_CONTROL_IN_MSGHDR )
|
|
|
|
if(HAVE_CONTROL_IN_MSGHDR)
|
|
#
|
|
# Check whether BSD 4.4 / RFC2292 style fd passing works
|
|
#
|
|
set(EXTRA_COMPILE_DEFINITIONS "")
|
|
if(HAVE_SYS_TYPES_H)
|
|
set(EXTRA_COMPILE_DEFINITIONS "${EXTRA_COMPILE_DEFINITIONS} -DHAVE_SYS_TYPES_H=1")
|
|
endif()
|
|
if(HAVE_SYS_UIO_H)
|
|
set(EXTRA_COMPILE_DEFINITIONS "${EXTRA_COMPILE_DEFINITIONS} -DHAVE_SYS_UIO_H=1")
|
|
endif()
|
|
|
|
# Try without _XOPEN_SOURCE first
|
|
try_run(
|
|
# Name of variable to store the run result (process exit status; number) in:
|
|
test_run_result
|
|
# Name of variable to store the compile result (TRUE or FALSE) in:
|
|
test_compile_result
|
|
# Binary directory:
|
|
${CMAKE_CURRENT_BINARY_DIR}
|
|
# Source file to be compiled:
|
|
${_selfdir_CheckFDPassing}/CheckFDPassing.c
|
|
# Extra -D Compile Definitions
|
|
COMPILE_DEFINITIONS ${EXTRA_COMPILE_DEFINITIONS}
|
|
# Where to store the output produced during compilation:
|
|
COMPILE_OUTPUT_VARIABLE test_compile_output
|
|
# Where to store the output produced by running the compiled executable:
|
|
RUN_OUTPUT_VARIABLE test_run_output )
|
|
|
|
# Did compilation succeed and process return 0 (success)?
|
|
if("${test_compile_result}" AND ("${test_run_result}" EQUAL 0))
|
|
set(HAVE_FD_PASSING 1)
|
|
else()
|
|
# Try again, this time with: #define _XOPEN_SOURCE 500
|
|
set(EXTRA_COMPILE_DEFINITIONS "${EXTRA_COMPILE_DEFINITIONS} -D_XOPEN_SOURCE=500")
|
|
|
|
try_run(
|
|
# Name of variable to store the run result (process exit status; number) in:
|
|
test_run_result
|
|
# Name of variable to store the compile result (TRUE or FALSE) in:
|
|
test_compile_result
|
|
# Binary directory:
|
|
${CMAKE_CURRENT_BINARY_DIR}
|
|
# Source file to be compiled:
|
|
${_selfdir_CheckFDPassing}/CheckFDPassing.c
|
|
# Extra -D Compile Definitions
|
|
COMPILE_DEFINITIONS ${EXTRA_COMPILE_DEFINITIONS}
|
|
# Where to store the output produced during compilation:
|
|
COMPILE_OUTPUT_VARIABLE test_compile_output
|
|
# Where to store the output produced by running the compiled executable:
|
|
RUN_OUTPUT_VARIABLE test_run_output )
|
|
|
|
# Did compilation succeed and process return 0 (success)?
|
|
if("${test_compile_result}" AND ("${test_run_result}" EQUAL 0))
|
|
set(HAVE_FD_PASSING 1)
|
|
set(FDPASS_NEED_XOPEN 1)
|
|
endif()
|
|
endif()
|
|
|
|
endif()
|