Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-31 04:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-32467: Let collections.abc.ValuesView inherit from Collection (#5152)

Browse source
This commit is contained in:
Raymond Hettinger 2018-01-11 21:53:49 -08:00 • committed by GitHub
parent 782d6fe443
commit 02556fbade
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Doc/library/collections.abc.rst
View file

@ -87,7 +87,8 @@ ABC Inherits from Abstract Methods Mixin
:class:`Set` ``__iter__``
:class:`KeysView` :class:`MappingView`, ``__contains__``,
:class:`Set` ``__iter__``
:class:`ValuesView` :class:`MappingView` ``__contains__``, ``__iter__``
:class:`ValuesView` :class:`MappingView`, ``__contains__``, ``__iter__``
:class:`Collection`
:class:`Awaitable` ``__await__``
:class:`Coroutine` :class:`Awaitable` ``send``, ``throw`` ``close``
:class:`AsyncIterable` ``__aiter__``

2
Lib/_collections_abc.py
View file

@ -746,7 +746,7 @@ def __iter__(self):
ItemsView.register(dict_items)
class ValuesView(MappingView):
class ValuesView(MappingView, Collection):
__slots__ = ()

4
Lib/test/test_collections.py
View file

@ -843,13 +843,13 @@ def test_Collection(self):
self.assertFalse(issubclass(type(x), Collection), repr(type(x)))
# Check some non-collection iterables
non_col_iterables = [_test_gen(), iter(b''), iter(bytearray()),
(x for x in []), dict().values()]
(x for x in [])]
for x in non_col_iterables:
self.assertNotIsInstance(x, Collection)
self.assertFalse(issubclass(type(x), Collection), repr(type(x)))
# Check some collections
samples = [set(), frozenset(), dict(), bytes(), str(), tuple(),
list(), dict().keys(), dict().items()]
list(), dict().keys(), dict().items(), dict().values()]
for x in samples:
self.assertIsInstance(x, Collection)
self.assertTrue(issubclass(type(x), Collection), repr(type(x)))

1
Misc/NEWS.d/next/Library/2018-01-11-00-33-42.bpo-32467.YVEOv6.rst Normal file
View file

@ -0,0 +1 @@
collections.abc.ValuesView now inherits from collections.abc.Collection.