Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-31 13:41:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-43390: Set SA_ONSTACK in PyOS_setsig (GH-24730)

Browse source 
This is friendlier to other in-process code that an extension module or
embedding use could pull in such as CGo where tiny stacks are the norm
and sigaltstack() has been used to provide for signal handlers.

Without this, signals received by a process using tiny stacks may lead
to stack overflow crashes.
This commit is contained in:
Gregory P. Smith 2021-03-04 21:49:30 -08:00 • committed by GitHub
parent 2122e48630
commit 02ac6f41e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Misc/NEWS.d/next/Core and Builtins/2021-03-03-17-58-49.bpo-43390.epPpwV.rst Normal file
View file

@ -0,0 +1,6 @@
CPython now sets the ``SA_ONSTACK`` flag in ``PyOS_setsig`` for the VM's
default signal handlers. This is friendlier to other in-process code that
an extension module or embedding use could pull in (such as Golang's cgo)
where tiny thread stacks are the norm and ``sigaltstack()`` has been used to
provide for signal handlers. This is a no-op change for the vast majority
of processes that don't use sigaltstack.

5
Python/pylifecycle.c
View file

@ -2884,7 +2884,10 @@ PyOS_setsig(int sig, PyOS_sighandler_t handler)
struct sigaction context, ocontext; struct sigaction context, ocontext;
context.sa_handler = handler; context.sa_handler = handler;
sigemptyset(&context.sa_mask); sigemptyset(&context.sa_mask);
context.sa_flags = 0; /* Using SA_ONSTACK is friendlier to other C/C++/Golang-VM code that
* extension module or embedding code may use where tiny thread stacks
* are used. https://bugs.python.org/issue43390 */
context.sa_flags = SA_ONSTACK;
if (sigaction(sig, &context, &ocontext) == -1) if (sigaction(sig, &context, &ocontext) == -1)
return SIG_ERR; return SIG_ERR;
return ocontext.sa_handler; return ocontext.sa_handler;