Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-30 21:21:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-44287: asyncio test_popen() uses longer timeout (GH-26832)

Browse source 
Fix asyncio test_popen() of test_windows_utils by using a longer
timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT
timeout rather than a hardcoded timeout of 10 seconds: it's 30
seconds by default, but it is made longer on slow buildbots.

WaitForMultipleObjects() timeout argument is in milliseconds.
(cherry picked from commit be1cb3214d)

Co-authored-by: Victor Stinner <vstinner@python.org>
This commit is contained in:
Miss Islington (bot) 2021-06-21 17:29:13 -07:00 • committed by GitHub
parent d881002fbd
commit 0ff487b8ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_asyncio/test_windows_utils.py
View file

@ -107,7 +107,8 @@ def test_popen(self):
events = [ovin.event, ovout.event, overr.event] events = [ovin.event, ovout.event, overr.event]
# Super-long timeout for slow buildbots. # Super-long timeout for slow buildbots.
res = _winapi.WaitForMultipleObjects(events, True, 10000) res = _winapi.WaitForMultipleObjects(events, True,
int(support.SHORT_TIMEOUT * 1000))
self.assertEqual(res, _winapi.WAIT_OBJECT_0) self.assertEqual(res, _winapi.WAIT_OBJECT_0)
self.assertFalse(ovout.pending) self.assertFalse(ovout.pending)
self.assertFalse(overr.pending) self.assertFalse(overr.pending)

4
Misc/NEWS.d/next/Tests/2021-06-21-17-53-41.bpo-44287.YON57s.rst Normal file
View file

@ -0,0 +1,4 @@
Fix asyncio test_popen() of test_windows_utils by using a longer timeout.
Use military grade battle-tested :data:`test.support.SHORT_TIMEOUT` timeout
rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but
it is made longer on slow buildbots. Patch by Victor Stinner.