mirror of
https://github.com/python/cpython.git
synced 2025-10-24 18:33:49 +00:00
[3.13] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518) (gh-137733)
There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:
* The loop over thread states could crash if a thread exits concurrently
(in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
thread-safe on the free threading build.
(cherry picked from commit a10152f8fd)
This commit is contained in:
Sam Gross
GitHub
parent
f6186a3709
commit
16d2e97cf3
12 changed files with 29814 additions and 29714 deletions
|
|
@ -137,17 +137,10 @@ sys_profile_call_or_return(
|
|||
Py_RETURN_NONE;
|
||||
}
|
||||
|
||||
int
|
||||
_PyEval_SetOpcodeTrace(
|
||||
PyFrameObject *frame,
|
||||
bool enable
|
||||
) {
|
||||
assert(frame != NULL);
|
||||
assert(PyCode_Check(frame->f_frame->f_executable));
|
||||
|
||||
PyCodeObject *code = (PyCodeObject *)frame->f_frame->f_executable;
|
||||
static int
|
||||
set_opcode_trace_world_stopped(PyCodeObject *code, bool enable)
|
||||
{
|
||||
_PyMonitoringEventSet events = 0;
|
||||
|
||||
if (_PyMonitoring_GetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, &events) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
|
@ -166,6 +159,32 @@ _PyEval_SetOpcodeTrace(
|
|||
return _PyMonitoring_SetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, events);
|
||||
}
|
||||
|
||||
int
|
||||
_PyEval_SetOpcodeTrace(PyFrameObject *frame, bool enable)
|
||||
{
|
||||
assert(frame != NULL);
|
||||
|
||||
PyCodeObject *code = _PyFrame_GetCode(frame->f_frame);
|
||||
|
||||
#ifdef Py_GIL_DISABLED
|
||||
// First check if a change is necessary outside of the stop-the-world pause
|
||||
_PyMonitoringEventSet events = 0;
|
||||
if (_PyMonitoring_GetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, &events) < 0) {
|
||||
return -1;
|
||||
}
|
||||
int is_enabled = (events & (1 << PY_MONITORING_EVENT_INSTRUCTION)) != 0;
|
||||
if (is_enabled == enable) {
|
||||
return 0; // No change needed
|
||||
}
|
||||
#endif
|
||||
|
||||
PyInterpreterState *interp = _PyInterpreterState_GET();
|
||||
_PyEval_StopTheWorld(interp);
|
||||
int res = set_opcode_trace_world_stopped(code, enable);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
return res;
|
||||
}
|
||||
|
||||
static PyObject *
|
||||
call_trace_func(_PyLegacyEventHandler *self, PyObject *arg)
|
||||
{
|
||||
|
|
@ -435,60 +454,72 @@ is_tstate_valid(PyThreadState *tstate)
|
|||
}
|
||||
#endif
|
||||
|
||||
static Py_ssize_t
|
||||
setup_profile(PyThreadState *tstate, Py_tracefunc func, PyObject *arg, PyObject **old_profileobj)
|
||||
static int
|
||||
setup_profile_callbacks(void *Py_UNUSED(arg))
|
||||
{
|
||||
*old_profileobj = NULL;
|
||||
/* Setup PEP 669 monitoring callbacks and events. */
|
||||
if (!tstate->interp->sys_profile_initialized) {
|
||||
tstate->interp->sys_profile_initialized = true;
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_start, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_START, PY_MONITORING_EVENT_PY_RESUME)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_throw, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_THROW, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_return, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_RETURN, PY_MONITORING_EVENT_PY_YIELD)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_unwind, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_UNWIND, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_CALL,
|
||||
PY_MONITORING_EVENT_CALL, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_RETURN,
|
||||
PY_MONITORING_EVENT_C_RETURN, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_EXCEPTION,
|
||||
PY_MONITORING_EVENT_C_RAISE, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_start, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_START, PY_MONITORING_EVENT_PY_RESUME)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_throw, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_THROW, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_return, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_RETURN, PY_MONITORING_EVENT_PY_YIELD)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_unwind, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_UNWIND, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_CALL,
|
||||
PY_MONITORING_EVENT_CALL, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_RETURN,
|
||||
PY_MONITORING_EVENT_C_RETURN, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_PROFILE_ID,
|
||||
(vectorcallfunc)sys_profile_call_or_return, PyTrace_C_EXCEPTION,
|
||||
PY_MONITORING_EVENT_C_RAISE, -1)) {
|
||||
return -1;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
_PyEval_StopTheWorld(tstate->interp);
|
||||
static PyObject *
|
||||
swap_profile_func_arg(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
|
||||
{
|
||||
int delta = (func != NULL) - (tstate->c_profilefunc != NULL);
|
||||
tstate->c_profilefunc = func;
|
||||
*old_profileobj = tstate->c_profileobj;
|
||||
PyObject *old_profileobj = tstate->c_profileobj;
|
||||
tstate->c_profileobj = Py_XNewRef(arg);
|
||||
tstate->interp->sys_profiling_threads += delta;
|
||||
assert(tstate->interp->sys_profiling_threads >= 0);
|
||||
Py_ssize_t profiling_threads = tstate->interp->sys_profiling_threads;
|
||||
_PyEval_StartTheWorld(tstate->interp);
|
||||
return profiling_threads;
|
||||
return old_profileobj;
|
||||
}
|
||||
|
||||
static int
|
||||
set_monitoring_profile_events(PyInterpreterState *interp)
|
||||
{
|
||||
uint32_t events = 0;
|
||||
if (interp->sys_profiling_threads) {
|
||||
events =
|
||||
(1 << PY_MONITORING_EVENT_PY_START) | (1 << PY_MONITORING_EVENT_PY_RESUME) |
|
||||
(1 << PY_MONITORING_EVENT_PY_RETURN) | (1 << PY_MONITORING_EVENT_PY_YIELD) |
|
||||
(1 << PY_MONITORING_EVENT_CALL) | (1 << PY_MONITORING_EVENT_PY_UNWIND) |
|
||||
(1 << PY_MONITORING_EVENT_PY_THROW);
|
||||
}
|
||||
return _PyMonitoring_SetEvents(PY_MONITORING_SYS_PROFILE_ID, events);
|
||||
}
|
||||
|
||||
int
|
||||
|
|
@ -505,88 +536,153 @@ _PyEval_SetProfile(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
|
|||
return -1;
|
||||
}
|
||||
|
||||
// needs to be decref'd outside of the lock
|
||||
PyObject *old_profileobj;
|
||||
LOCK_SETUP();
|
||||
Py_ssize_t profiling_threads = setup_profile(tstate, func, arg, &old_profileobj);
|
||||
UNLOCK_SETUP();
|
||||
Py_XDECREF(old_profileobj);
|
||||
|
||||
uint32_t events = 0;
|
||||
if (profiling_threads) {
|
||||
events =
|
||||
(1 << PY_MONITORING_EVENT_PY_START) | (1 << PY_MONITORING_EVENT_PY_RESUME) |
|
||||
(1 << PY_MONITORING_EVENT_PY_RETURN) | (1 << PY_MONITORING_EVENT_PY_YIELD) |
|
||||
(1 << PY_MONITORING_EVENT_CALL) | (1 << PY_MONITORING_EVENT_PY_UNWIND) |
|
||||
(1 << PY_MONITORING_EVENT_PY_THROW);
|
||||
PyInterpreterState *interp = tstate->interp;
|
||||
if (_PyOnceFlag_CallOnce(&interp->sys_profile_once_flag,
|
||||
setup_profile_callbacks, NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
return _PyMonitoring_SetEvents(PY_MONITORING_SYS_PROFILE_ID, events);
|
||||
|
||||
_PyEval_StopTheWorld(interp);
|
||||
PyObject *old_profileobj = swap_profile_func_arg(tstate, func, arg);
|
||||
int ret = set_monitoring_profile_events(interp);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
Py_XDECREF(old_profileobj); // needs to be decref'd outside of stop-the-world
|
||||
return ret;
|
||||
}
|
||||
|
||||
static Py_ssize_t
|
||||
setup_tracing(PyThreadState *tstate, Py_tracefunc func, PyObject *arg, PyObject **old_traceobj)
|
||||
int
|
||||
_PyEval_SetProfileAllThreads(PyInterpreterState *interp, Py_tracefunc func, PyObject *arg)
|
||||
{
|
||||
*old_traceobj = NULL;
|
||||
/* Setup PEP 669 monitoring callbacks and events. */
|
||||
if (!tstate->interp->sys_trace_initialized) {
|
||||
tstate->interp->sys_trace_initialized = true;
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_start, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_START, PY_MONITORING_EVENT_PY_RESUME)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_throw, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_THROW, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_return, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_RETURN, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_yield, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_YIELD, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_exception_func, PyTrace_EXCEPTION,
|
||||
PY_MONITORING_EVENT_RAISE, PY_MONITORING_EVENT_STOP_ITERATION)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_line_func, PyTrace_LINE,
|
||||
PY_MONITORING_EVENT_LINE, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_unwind, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_UNWIND, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_jump_func, PyTrace_LINE,
|
||||
PY_MONITORING_EVENT_JUMP, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_instruction_func, PyTrace_OPCODE,
|
||||
PY_MONITORING_EVENT_INSTRUCTION, -1)) {
|
||||
return -1;
|
||||
}
|
||||
PyThreadState *current_tstate = _PyThreadState_GET();
|
||||
assert(is_tstate_valid(current_tstate));
|
||||
assert(current_tstate->interp == interp);
|
||||
|
||||
if (_PySys_Audit(current_tstate, "sys.setprofile", NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
_PyEval_StopTheWorld(tstate->interp);
|
||||
if (_PyOnceFlag_CallOnce(&interp->sys_profile_once_flag,
|
||||
setup_profile_callbacks, NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
PyObject *old_profileobjs = NULL;
|
||||
_PyEval_StopTheWorld(interp);
|
||||
HEAD_LOCK(&_PyRuntime);
|
||||
Py_ssize_t num_thread_states = 0;
|
||||
for (PyThreadState *p = interp->threads.head; p; p = p->next) {
|
||||
num_thread_states++;
|
||||
}
|
||||
old_profileobjs = PyTuple_New(num_thread_states);
|
||||
if (old_profileobjs == NULL) {
|
||||
HEAD_UNLOCK(&_PyRuntime);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
return -1;
|
||||
}
|
||||
for (PyThreadState *tstate = interp->threads.head; tstate; tstate = tstate->next) {
|
||||
PyObject *old = swap_profile_func_arg(tstate, func, arg);
|
||||
PyTuple_SET_ITEM(old_profileobjs, --num_thread_states, old);
|
||||
}
|
||||
HEAD_UNLOCK(&_PyRuntime);
|
||||
int ret = set_monitoring_profile_events(interp);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
Py_XDECREF(old_profileobjs); // needs to be decref'd outside of stop-the-world
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int
|
||||
setup_trace_callbacks(void *Py_UNUSED(arg))
|
||||
{
|
||||
/* Setup PEP 669 monitoring callbacks and events. */
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_start, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_START, PY_MONITORING_EVENT_PY_RESUME)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_throw, PyTrace_CALL,
|
||||
PY_MONITORING_EVENT_PY_THROW, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_return, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_RETURN, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_yield, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_YIELD, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_exception_func, PyTrace_EXCEPTION,
|
||||
PY_MONITORING_EVENT_RAISE, PY_MONITORING_EVENT_STOP_ITERATION)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_line_func, PyTrace_LINE,
|
||||
PY_MONITORING_EVENT_LINE, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_unwind, PyTrace_RETURN,
|
||||
PY_MONITORING_EVENT_PY_UNWIND, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_jump_func, PyTrace_LINE,
|
||||
PY_MONITORING_EVENT_JUMP, -1)) {
|
||||
return -1;
|
||||
}
|
||||
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
|
||||
(vectorcallfunc)sys_trace_instruction_func, PyTrace_OPCODE,
|
||||
PY_MONITORING_EVENT_INSTRUCTION, -1)) {
|
||||
return -1;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
static PyObject *
|
||||
swap_trace_func_arg(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
|
||||
{
|
||||
int delta = (func != NULL) - (tstate->c_tracefunc != NULL);
|
||||
tstate->c_tracefunc = func;
|
||||
*old_traceobj = tstate->c_traceobj;
|
||||
PyObject *old_traceobj = tstate->c_traceobj;
|
||||
tstate->c_traceobj = Py_XNewRef(arg);
|
||||
tstate->interp->sys_tracing_threads += delta;
|
||||
assert(tstate->interp->sys_tracing_threads >= 0);
|
||||
Py_ssize_t tracing_threads = tstate->interp->sys_tracing_threads;
|
||||
_PyEval_StartTheWorld(tstate->interp);
|
||||
return tracing_threads;
|
||||
return old_traceobj;
|
||||
}
|
||||
|
||||
static int
|
||||
set_monitoring_trace_events(PyInterpreterState *interp)
|
||||
{
|
||||
uint32_t events = 0;
|
||||
if (interp->sys_tracing_threads) {
|
||||
events =
|
||||
(1 << PY_MONITORING_EVENT_PY_START) | (1 << PY_MONITORING_EVENT_PY_RESUME) |
|
||||
(1 << PY_MONITORING_EVENT_PY_RETURN) | (1 << PY_MONITORING_EVENT_PY_YIELD) |
|
||||
(1 << PY_MONITORING_EVENT_RAISE) | (1 << PY_MONITORING_EVENT_LINE) |
|
||||
(1 << PY_MONITORING_EVENT_JUMP) |
|
||||
(1 << PY_MONITORING_EVENT_PY_UNWIND) | (1 << PY_MONITORING_EVENT_PY_THROW) |
|
||||
(1 << PY_MONITORING_EVENT_STOP_ITERATION);
|
||||
}
|
||||
return _PyMonitoring_SetEvents(PY_MONITORING_SYS_TRACE_ID, events);
|
||||
}
|
||||
|
||||
// Enable opcode tracing for the thread's current frame if needed.
|
||||
static int
|
||||
maybe_set_opcode_trace(PyThreadState *tstate)
|
||||
{
|
||||
_PyInterpreterFrame *iframe = tstate->current_frame;
|
||||
if (iframe == NULL) {
|
||||
return 0;
|
||||
}
|
||||
PyFrameObject *frame = iframe->frame_obj;
|
||||
if (frame == NULL || !frame->f_trace_opcodes) {
|
||||
return 0;
|
||||
}
|
||||
return set_opcode_trace_world_stopped(_PyFrame_GetCode(iframe), true);
|
||||
}
|
||||
|
||||
int
|
||||
|
|
@ -602,35 +698,76 @@ _PyEval_SetTrace(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
|
|||
if (_PySys_Audit(current_tstate, "sys.settrace", NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
// needs to be decref'd outside of the lock
|
||||
PyObject *old_traceobj;
|
||||
LOCK_SETUP();
|
||||
assert(tstate->interp->sys_tracing_threads >= 0);
|
||||
Py_ssize_t tracing_threads = setup_tracing(tstate, func, arg, &old_traceobj);
|
||||
UNLOCK_SETUP();
|
||||
Py_XDECREF(old_traceobj);
|
||||
if (tracing_threads < 0) {
|
||||
|
||||
PyInterpreterState *interp = tstate->interp;
|
||||
if (_PyOnceFlag_CallOnce(&interp->sys_trace_once_flag,
|
||||
setup_trace_callbacks, NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
uint32_t events = 0;
|
||||
if (tracing_threads) {
|
||||
events =
|
||||
(1 << PY_MONITORING_EVENT_PY_START) | (1 << PY_MONITORING_EVENT_PY_RESUME) |
|
||||
(1 << PY_MONITORING_EVENT_PY_RETURN) | (1 << PY_MONITORING_EVENT_PY_YIELD) |
|
||||
(1 << PY_MONITORING_EVENT_RAISE) | (1 << PY_MONITORING_EVENT_LINE) |
|
||||
(1 << PY_MONITORING_EVENT_JUMP) |
|
||||
(1 << PY_MONITORING_EVENT_PY_UNWIND) | (1 << PY_MONITORING_EVENT_PY_THROW) |
|
||||
(1 << PY_MONITORING_EVENT_STOP_ITERATION);
|
||||
int err = 0;
|
||||
_PyEval_StopTheWorld(interp);
|
||||
PyObject *old_traceobj = swap_trace_func_arg(tstate, func, arg);
|
||||
err = set_monitoring_trace_events(interp);
|
||||
if (err != 0) {
|
||||
goto done;
|
||||
}
|
||||
if (interp->sys_tracing_threads) {
|
||||
err = maybe_set_opcode_trace(tstate);
|
||||
}
|
||||
done:
|
||||
_PyEval_StartTheWorld(interp);
|
||||
Py_XDECREF(old_traceobj); // needs to be decref'd outside stop-the-world
|
||||
return err;
|
||||
}
|
||||
|
||||
PyFrameObject* frame = PyEval_GetFrame();
|
||||
if (frame && frame->f_trace_opcodes) {
|
||||
int ret = _PyEval_SetOpcodeTrace(frame, true);
|
||||
if (ret != 0) {
|
||||
return ret;
|
||||
int
|
||||
_PyEval_SetTraceAllThreads(PyInterpreterState *interp, Py_tracefunc func, PyObject *arg)
|
||||
{
|
||||
PyThreadState *current_tstate = _PyThreadState_GET();
|
||||
assert(is_tstate_valid(current_tstate));
|
||||
assert(current_tstate->interp == interp);
|
||||
|
||||
if (_PySys_Audit(current_tstate, "sys.settrace", NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (_PyOnceFlag_CallOnce(&interp->sys_trace_once_flag,
|
||||
setup_trace_callbacks, NULL) < 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
PyObject *old_trace_objs = NULL;
|
||||
_PyEval_StopTheWorld(interp);
|
||||
HEAD_LOCK(&_PyRuntime);
|
||||
Py_ssize_t num_thread_states = 0;
|
||||
for (PyThreadState *p = interp->threads.head; p; p = p->next) {
|
||||
num_thread_states++;
|
||||
}
|
||||
old_trace_objs = PyTuple_New(num_thread_states);
|
||||
if (old_trace_objs == NULL) {
|
||||
HEAD_UNLOCK(&_PyRuntime);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
return -1;
|
||||
}
|
||||
for (PyThreadState *tstate = interp->threads.head; tstate; tstate = tstate->next) {
|
||||
PyObject *old = swap_trace_func_arg(tstate, func, arg);
|
||||
PyTuple_SET_ITEM(old_trace_objs, --num_thread_states, old);
|
||||
}
|
||||
if (interp->sys_tracing_threads) {
|
||||
for (PyThreadState *tstate = interp->threads.head; tstate; tstate = tstate->next) {
|
||||
int err = maybe_set_opcode_trace(tstate);
|
||||
if (err != 0) {
|
||||
HEAD_UNLOCK(&_PyRuntime);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
Py_XDECREF(old_trace_objs);
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return _PyMonitoring_SetEvents(PY_MONITORING_SYS_TRACE_ID, events);
|
||||
HEAD_UNLOCK(&_PyRuntime);
|
||||
int err = set_monitoring_trace_events(interp);
|
||||
_PyEval_StartTheWorld(interp);
|
||||
Py_XDECREF(old_trace_objs); // needs to be decref'd outside of stop-the-world
|
||||
return err;
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue