Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-04-13 15:20:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-145566: Skip stop-the-world when reassigning __class__ on newly created objects (gh-145567)

Browse source
This commit is contained in:
Sam Gross 2026-03-06 12:01:06 -05:00 • committed by GitHub
parent b28e5f58eb
commit 1d091a336e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS.d/next/Core_and_Builtins/2026-03-05-19-10-56.gh-issue-145566.H4RupyYN.rst Normal file
View file

@ -0,0 +1,2 @@
In the free threading build, skip the stop-the-world pause when reassigning
``__class__`` on a newly created object.

15
Objects/typeobject.c
View file

@ -7568,7 +7568,11 @@ object_set_class_world_stopped(PyObject *self, PyTypeObject *newto)
assert(_PyObject_GetManagedDict(self) == dict);
if (_PyDict_DetachFromObject(dict, self) < 0) {
int err;
Py_BEGIN_CRITICAL_SECTION(dict);
err = _PyDict_DetachFromObject(dict, self);
Py_END_CRITICAL_SECTION();
if (err < 0) {
return -1;
}
@ -7608,10 +7612,15 @@ object_set_class(PyObject *self, PyObject *value, void *closure)
return -1;
}
types_stop_world();
int unique = _PyObject_IsUniquelyReferenced(self);
if (!unique) {
types_stop_world();
}
PyTypeObject *oldto = Py_TYPE(self);
int res = object_set_class_world_stopped(self, newto);
types_start_world();
if (!unique) {
types_start_world();
}
if (res == 0) {
if (oldto->tp_flags & Py_TPFLAGS_HEAPTYPE) {
Py_DECREF(oldto);