Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor and optimize RepackHelperMixin

Browse source
This commit is contained in:
Danny Lin 2025-06-14 13:53:40 +08:00
parent c759b639ee
commit 1ece5b17d5
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Lib/test/test_zipfile/test_core.py
View file

@ -1379,9 +1379,18 @@ def struct_pack_no_dd_sig(fmt, *values):
class RepackHelperMixin: class RepackHelperMixin:
"""Common helpers for remove and repack.""" """Common helpers for remove and repack."""
def _prepare_zip_from_test_files(self, zfname, test_files, force_zip64=False): @classmethod
def _prepare_test_files(cls):
return [
('file0.txt', b'Lorem ipsum dolor sit amet, consectetur adipiscing elit'),
('file1.txt', b'Duis aute irure dolor in reprehenderit in voluptate velit esse'),
('file2.txt', b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem'),
]
@classmethod
def _prepare_zip_from_test_files(cls, zfname, test_files, force_zip64=False):
zinfos = [] zinfos = []
with zipfile.ZipFile(zfname, 'w', self.compression) as zh: with zipfile.ZipFile(zfname, 'w', cls.compression) as zh:
for file, data in test_files: for file, data in test_files:
with zh.open(file, 'w', force_zip64=force_zip64) as fh: with zh.open(file, 'w', force_zip64=force_zip64) as fh:
fh.write(data) fh.write(data)
@ -1392,11 +1401,7 @@ def _prepare_zip_from_test_files(self, zfname, test_files, force_zip64=False):
class AbstractRemoveTests(RepackHelperMixin): class AbstractRemoveTests(RepackHelperMixin):
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
cls.test_files = [ cls.test_files = cls._prepare_test_files()
('file0.txt', b'Lorem ipsum dolor sit amet, consectetur adipiscing elit'),
('file1.txt', b'Duis aute irure dolor in reprehenderit in voluptate velit esse'),
('file2.txt', b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem'),
]
def tearDown(self): def tearDown(self):
unlink(TESTFN) unlink(TESTFN)
@ -1683,11 +1688,7 @@ class ZstdRemoveTests(AbstractRemoveTests, unittest.TestCase):
class AbstractRepackTests(RepackHelperMixin): class AbstractRepackTests(RepackHelperMixin):
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
cls.test_files = [ cls.test_files = cls._prepare_test_files()
('file0.txt', b'Lorem ipsum dolor sit amet, consectetur adipiscing elit'),
('file1.txt', b'Duis aute irure dolor in reprehenderit in voluptate velit esse'),
('file2.txt', b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem'),
]
def tearDown(self): def tearDown(self):
unlink(TESTFN) unlink(TESTFN)