Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-30 21:21:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-45662: Fix the repr of InitVar with a type alias to the built-in class (GH-29291)

Browse source 
For example, InitVar[list[int]].
This commit is contained in:
Serhiy Storchaka 2021-12-05 22:41:58 +02:00 • committed by GitHub
parent 60c320c38e
commit 1fd4de5bdd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/dataclasses.py
View file

@ -229,7 +229,7 @@ def __init__(self, type):
self.type = type self.type = type
def __repr__(self): def __repr__(self):
if isinstance(self.type, type): if isinstance(self.type, type) and not isinstance(self.type, GenericAlias):
type_name = self.type.__name__ type_name = self.type.__name__
else: else:
# typing objects, e.g. List[int] # typing objects, e.g. List[int]

4
Lib/test/test_dataclasses.py
View file

@ -1126,6 +1126,10 @@ def test_init_var_preserve_type(self):
self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]') self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]')
self.assertEqual(repr(InitVar[List[int]]), self.assertEqual(repr(InitVar[List[int]]),
'dataclasses.InitVar[typing.List[int]]') 'dataclasses.InitVar[typing.List[int]]')
self.assertEqual(repr(InitVar[list[int]]),
'dataclasses.InitVar[list[int]]')
self.assertEqual(repr(InitVar[int|str]),
'dataclasses.InitVar[int | str]')
def test_init_var_inheritance(self): def test_init_var_inheritance(self):
# Note that this deliberately tests that a dataclass need not # Note that this deliberately tests that a dataclass need not

2
Misc/NEWS.d/next/Library/2021-10-28-22-58-14.bpo-45662.sJd7Ir.rst Normal file
View file

@ -0,0 +1,2 @@
Fix the repr of :data:`dataclasses.InitVar` with a type alias to the
built-in class, e.g. ``InitVar[list[int]]``.