mirror of
				https://github.com/python/cpython.git
				synced 2025-10-31 13:41:24 +00:00 
			
		
		
		
	Use PyOS_snprintf when possible.
This commit is contained in:
		
							parent
							
								
									885d457709
								
							
						
					
					
						commit
						23ae987401
					
				
					 1 changed files with 41 additions and 34 deletions
				
			
		|  | @ -135,7 +135,8 @@ vgetargs1(PyObject *args, char *format, va_list *p_va, int compat) | |||
| 		if (max == 0) { | ||||
| 			if (args == NULL) | ||||
| 				return 1; | ||||
| 			sprintf(msgbuf, "%.200s%s takes no arguments", | ||||
| 			PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 				      "%.200s%s takes no arguments", | ||||
| 				      fname==NULL ? "function" : fname, | ||||
| 				      fname==NULL ? "" : "()"); | ||||
| 			PyErr_SetString(PyExc_TypeError, msgbuf); | ||||
|  | @ -143,7 +144,7 @@ vgetargs1(PyObject *args, char *format, va_list *p_va, int compat) | |||
| 		} | ||||
| 		else if (min == 1 && max == 1) { | ||||
| 			if (args == NULL) { | ||||
| 				sprintf(msgbuf, | ||||
| 				PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 				      "%.200s%s takes at least one argument", | ||||
| 					      fname==NULL ? "function" : fname, | ||||
| 					      fname==NULL ? "" : "()"); | ||||
|  | @ -173,8 +174,9 @@ vgetargs1(PyObject *args, char *format, va_list *p_va, int compat) | |||
| 	 | ||||
| 	if (len < min || max < len) { | ||||
| 		if (message == NULL) { | ||||
| 			sprintf(msgbuf, | ||||
| 				"%.150s%s takes %s %d argument%s (%d given)", | ||||
| 			PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 				      "%.150s%s takes %s %d argument%s " | ||||
| 				      "(%d given)", | ||||
| 				      fname==NULL ? "function" : fname, | ||||
| 				      fname==NULL ? "" : "()", | ||||
| 				      min==max ? "exactly" | ||||
|  | @ -222,6 +224,7 @@ seterror(int iarg, char *msg, int *levels, char *fname, char *message) | |||
| 	if (PyErr_Occurred()) | ||||
| 		return; | ||||
| 	else if (message == NULL) { | ||||
| 		/* XXX snprintf */ | ||||
| 		if (fname != NULL) { | ||||
| 			sprintf(p, "%.200s() ", fname); | ||||
| 			p += strlen(p); | ||||
|  | @ -294,16 +297,17 @@ converttuple(PyObject *arg, char **p_format, va_list *p_va, int *levels, | |||
| 	 | ||||
| 	if (!PySequence_Check(arg) || PyString_Check(arg)) { | ||||
| 		levels[0] = 0; | ||||
| 		sprintf(msgbuf, | ||||
| 		PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 			      toplevel ? "expected %d arguments, not %.50s" : | ||||
| 			              "must be %d-item sequence, not %.50s", | ||||
| 			n, arg == Py_None ? "None" : arg->ob_type->tp_name); | ||||
| 			      n,  | ||||
| 			      arg == Py_None ? "None" : arg->ob_type->tp_name); | ||||
| 		return msgbuf; | ||||
| 	} | ||||
| 	 | ||||
| 	if ((i = PySequence_Size(arg)) != n) { | ||||
| 		levels[0] = 0; | ||||
| 		sprintf(msgbuf, | ||||
| 		PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 			      toplevel ? "expected %d arguments, not %d" : | ||||
| 			             "must be sequence of length %d, not %d", | ||||
| 			      n, i); | ||||
|  | @ -366,7 +370,9 @@ converterr(char *expected, PyObject *arg, char *msgbuf) | |||
| { | ||||
| 	assert(expected != NULL); | ||||
| 	assert(arg != NULL);  | ||||
| 	sprintf(msgbuf, "must be %.50s, not %.50s", expected, | ||||
| 	/* XXX use snprintf? */ | ||||
| 	sprintf(msgbuf, | ||||
| 		"must be %.50s, not %.50s", expected, | ||||
| 		arg == Py_None ? "None" : arg->ob_type->tp_name); | ||||
| 	return msgbuf; | ||||
| } | ||||
|  | @ -1129,8 +1135,9 @@ vgetargskeywords(PyObject *args, PyObject *keywords, char *format, | |||
| 	   are not included in the "%d given" part of the message */ | ||||
| 	if (len < min || max < len) { | ||||
| 		if (message == NULL) { | ||||
| 			sprintf(msgbuf, | ||||
| 				"%.200s%s takes %s %d argument%s (%d given)", | ||||
| 			PyOS_snprintf(msgbuf, sizeof(msgbuf), | ||||
| 				      "%.200s%s takes %s %d argument%s " | ||||
| 				      "(%d given)", | ||||
| 				      fname==NULL ? "function" : fname, | ||||
| 				      fname==NULL ? "" : "()", | ||||
| 				      min==max ? "exactly" | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Jeremy Hylton
						Jeremy Hylton