Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-04-13 15:20:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

GH-144688: Fix refleaks in JIT when optimization fails (GH-145420)

Browse source
This commit is contained in:
Mark Shannon 2026-03-09 15:21:33 +00:00 • committed by GitHub
parent 0dfe649400
commit 27c49707df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Python/optimizer.c
View file

@ -1076,12 +1076,19 @@ _PyJit_FinalizeTracing(PyThreadState *tstate, int err)
exit->temperature = initial_temperature_backoff_counter(&tstate->interp->opt_config);
}
}
// Clear all recorded values
_PyJitUopBuffer *buffer = &tracer->code_buffer;
for (_PyUOpInstruction *inst = buffer->start; inst < buffer->next; inst++) {
if (_PyUop_Flags[inst->opcode] & HAS_RECORDS_VALUE_FLAG) {
Py_XDECREF((PyObject *)(uintptr_t)inst->operand0);
}
}
Py_CLEAR(tracer->initial_state.code);
Py_CLEAR(tracer->initial_state.func);
Py_CLEAR(tracer->initial_state.executor);
Py_CLEAR(tracer->prev_state.instr_code);
Py_CLEAR(tracer->prev_state.recorded_value);
uop_buffer_init(&tracer->code_buffer, &tracer->uop_array[0], UOP_MAX_TRACE_LENGTH);
uop_buffer_init(buffer, &tracer->uop_array[0], UOP_MAX_TRACE_LENGTH);
tracer->is_tracing = false;
}
@ -1521,6 +1528,11 @@ uop_optimize(
}
assert(_PyOpcode_uop_name[buffer[pc].opcode]);
}
// We've cleaned up the references in the buffer, so discard the code buffer
// to avoid doing it again during tracer cleanup
_PyJitUopBuffer *code_buffer = &_tstate->jit_tracer_state->code_buffer;
code_buffer->next = code_buffer->start;
OPT_HIST(effective_trace_length(buffer, length), optimized_trace_length_hist);
_PyUOpInstruction *output = &_tstate->jit_tracer_state->uop_array[0];
length = stack_allocate(buffer, output, length);