Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH (GH-27623)

Browse source 
Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
This commit is contained in:
Miss Islington (bot) 2021-08-06 06:40:44 -07:00 • committed by GitHub
parent a11158ecef
commit 2ae2235c7a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Misc/NEWS.d/next/Library/2021-08-06-13-00-28.bpo-44849.O78F_f.rst Normal file
View file

@ -0,0 +1,4 @@
Fix the :func:`os.set_inheritable` function on FreeBSD 14 for file descriptor
opened with the :data:`~os.O_PATH` flag: ignore the :data:`~errno.EBADF`
error on ``ioctl()``, fallback on the ``fcntl()`` implementation. Patch by
Victor Stinner.

7
Python/fileutils.c
View file

@ -1374,10 +1374,11 @@ set_inheritable(int fd, int inheritable, int raise, int *atomic_flag_works)
return 0; return 0;
} }
#ifdef __linux__ #ifdef O_PATH
if (errno == EBADF) { if (errno == EBADF) {
// On Linux, ioctl(FIOCLEX) will fail with EBADF for O_PATH file descriptors // bpo-44849: On Linux and FreeBSD, ioctl(FIOCLEX) fails with EBADF
// Fall through to the fcntl() path // on O_PATH file descriptors. Fall through to the fcntl()
// implementation.
} }
else else
#endif #endif