Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Test for zip64 more thoroughly

Browse source
This commit is contained in:
Danny Lin 2025-05-21 23:28:44 +08:00
parent bb90f48f60
commit 2d74501e03
1 changed files with 11 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

37
Lib/test/test_zipfile/test_core.py
View file

@ -1362,7 +1362,7 @@ class ZstdWriterTests(AbstractWriterTests, unittest.TestCase):
class AbstractRemoveTests: class AbstractRemoveTests:
def _test_removing_members(self, test_files, indexes): def _test_removing_members(self, test_files, indexes, force_zip64=False):
"""Test underlying _remove_members() for removing members at given """Test underlying _remove_members() for removing members at given
indexes.""" indexes."""
# calculate the expected results # calculate the expected results
@ -1370,14 +1370,16 @@ def _test_removing_members(self, test_files, indexes):
with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh: with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh:
for i, (file, data) in enumerate(test_files): for i, (file, data) in enumerate(test_files):
if i not in indexes: if i not in indexes:
zh.writestr(file, data) with zh.open(file, 'w', force_zip64=force_zip64) as fh:
fh.write(data)
expected_files.append(file) expected_files.append(file)
expected_size = os.path.getsize(TESTFN) expected_size = os.path.getsize(TESTFN)
# prepare the test zip # prepare the test zip
with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh: with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh:
for file, data in test_files: for file, data in test_files:
zh.writestr(file, data) with zh.open(file, 'w', force_zip64=force_zip64) as fh:
fh.write(data)
# do the removal and check the result # do the removal and check the result
with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh: with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh:
@ -1550,30 +1552,13 @@ def test_verify(self):
def test_zip64(self): def test_zip64(self):
"""Test if members use zip64.""" """Test if members use zip64."""
file = 'datafile.txt' test_files = [
file1 = 'pre.txt' ('pre.txt', b'Lorem ipsum dolor sit amet, consectetur adipiscing elit'),
file2 = 'post.txt' ('datafile', b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem'),
data = b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem' ('post.txt', b'Duis aute irure dolor in reprehenderit in voluptate velit esse'),
data1 = b'Lorem ipsum dolor sit amet, consectetur adipiscing elit' ]
data2 = b'Duis aute irure dolor in reprehenderit in voluptate velit esse'
with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh:
with zh.open(file1, 'w', force_zip64=True) as fh:
fh.write(data1)
with zh.open(file2, 'w', force_zip64=True) as fh:
fh.write(data2)
expected_size = os.path.getsize(TESTFN)
with zipfile.ZipFile(TESTFN, 'w', self.compression) as zh: self._test_removing_members(test_files, [1], force_zip64=True)
with zh.open(file1, 'w', force_zip64=True) as fh:
fh.write(data1)
with zh.open(file, 'w', force_zip64=True) as fh:
fh.write(data)
with zh.open(file2, 'w', force_zip64=True) as fh:
fh.write(data2)
with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh:
zh.remove(file)
self.assertIsNone(zh.testzip())
self.assertEqual(os.path.getsize(TESTFN), expected_size)
class StoredRemoveTests(AbstractRemoveTests, unittest.TestCase): class StoredRemoveTests(AbstractRemoveTests, unittest.TestCase):
compression = zipfile.ZIP_STORED compression = zipfile.ZIP_STORED