gh-127020: Make PyCode_GetCode thread-safe for free threading (#127043)

Some fields in PyCodeObject are lazily initialized. Use atomics and
critical sections to make their initializations and accesses thread-safe.
This commit is contained in:
Sam Gross 2024-11-21 16:00:50 +00:00 committed by GitHub
parent dc7a2b6522
commit 3926842117
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 86 additions and 28 deletions

View file

@ -0,0 +1,30 @@
import unittest
from threading import Thread
from unittest import TestCase
from test.support import threading_helper
@threading_helper.requires_working_threading()
class TestCode(TestCase):
def test_code_attrs(self):
"""Test concurrent accesses to lazily initialized code attributes"""
code_objects = []
for _ in range(1000):
code_objects.append(compile("a + b", "<string>", "eval"))
def run_in_thread():
for code in code_objects:
self.assertIsInstance(code.co_code, bytes)
self.assertIsInstance(code.co_freevars, tuple)
self.assertIsInstance(code.co_varnames, tuple)
threads = [Thread(target=run_in_thread) for _ in range(2)]
for thread in threads:
thread.start()
for thread in threads:
thread.join()
if __name__ == "__main__":
unittest.main()