mirror of
				https://github.com/python/cpython.git
				synced 2025-10-31 13:41:24 +00:00 
			
		
		
		
	bpo-42630: Improve error reporting in Tkinter for absent default root (GH-23781)
* Tkinter functions and constructors which need a default root window raise now RuntimeError with descriptive message instead of obscure AttributeError or NameError if it is not created yet or cannot be created automatically. * Add tests for all functions which use default root window. * Fix import in the pynche script.
This commit is contained in:
		
							parent
							
								
									1e27b57dbc
								
							
						
					
					
						commit
						3d569fd6dc
					
				
					 19 changed files with 315 additions and 87 deletions
				
			
		|  | @ -36,6 +36,33 @@ def tearDown(self): | |||
|             w.destroy() | ||||
|         self.root.withdraw() | ||||
| 
 | ||||
| 
 | ||||
| class AbstractDefaultRootTest: | ||||
| 
 | ||||
|     def setUp(self): | ||||
|         self._old_support_default_root = tkinter._support_default_root | ||||
|         destroy_default_root() | ||||
|         tkinter._support_default_root = True | ||||
|         self.wantobjects = tkinter.wantobjects | ||||
| 
 | ||||
|     def tearDown(self): | ||||
|         destroy_default_root() | ||||
|         tkinter._default_root = None | ||||
|         tkinter._support_default_root = self._old_support_default_root | ||||
| 
 | ||||
|     def _test_widget(self, constructor): | ||||
|         # no master passing | ||||
|         x = constructor() | ||||
|         self.assertIsNotNone(tkinter._default_root) | ||||
|         self.assertIs(x.master, tkinter._default_root) | ||||
|         self.assertIs(x.tk, tkinter._default_root.tk) | ||||
|         x.destroy() | ||||
|         destroy_default_root() | ||||
|         tkinter.NoDefaultRoot() | ||||
|         self.assertRaises(RuntimeError, constructor) | ||||
|         self.assertFalse(hasattr(tkinter, '_default_root')) | ||||
| 
 | ||||
| 
 | ||||
| def destroy_default_root(): | ||||
|     if getattr(tkinter, '_default_root', None): | ||||
|         tkinter._default_root.update_idletasks() | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Serhiy Storchaka
						Serhiy Storchaka