mirror of
				https://github.com/python/cpython.git
				synced 2025-10-30 21:21:22 +00:00 
			
		
		
		
	gh-94192: Fix error for dictionary literals with invalid expression as value. (GH-94304)
* Fix error for dictionary literals with invalid expression as value.
* Remove trailing whitespace
(cherry picked from commit 8c237a7a71)
Co-authored-by: wookie184 <wookie1840@gmail.com>
			
			
This commit is contained in:
		
							parent
							
								
									1b27ec5ac6
								
							
						
					
					
						commit
						442dd8ffa5
					
				
					 4 changed files with 525 additions and 449 deletions
				
			
		|  | @ -1314,4 +1314,4 @@ invalid_kvpair: | ||||||
|     | a=expression !(':') { |     | a=expression !(':') { | ||||||
|         RAISE_ERROR_KNOWN_LOCATION(p, PyExc_SyntaxError, a->lineno, a->end_col_offset - 1, a->end_lineno, -1, "':' expected after dictionary key") } |         RAISE_ERROR_KNOWN_LOCATION(p, PyExc_SyntaxError, a->lineno, a->end_col_offset - 1, a->end_lineno, -1, "':' expected after dictionary key") } | ||||||
|     | expression ':' a='*' bitwise_or { RAISE_SYNTAX_ERROR_STARTING_FROM(a, "cannot use a starred expression in a dictionary value") } |     | expression ':' a='*' bitwise_or { RAISE_SYNTAX_ERROR_STARTING_FROM(a, "cannot use a starred expression in a dictionary value") } | ||||||
|     | expression a=':' {RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "expression expected after dictionary key and ':'") } |     | expression a=':' &('}'|',') {RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "expression expected after dictionary key and ':'") } | ||||||
|  |  | ||||||
|  | @ -1265,12 +1265,22 @@ | ||||||
|    Traceback (most recent call last): |    Traceback (most recent call last): | ||||||
|    SyntaxError: expression expected after dictionary key and ':' |    SyntaxError: expression expected after dictionary key and ':' | ||||||
| 
 | 
 | ||||||
|    # Ensure that the error is not raise for syntax errors that happen after sets |    # Ensure that the error is not raised for syntax errors that happen after sets | ||||||
| 
 | 
 | ||||||
|    >>> {1} $ |    >>> {1} $ | ||||||
|    Traceback (most recent call last): |    Traceback (most recent call last): | ||||||
|    SyntaxError: invalid syntax |    SyntaxError: invalid syntax | ||||||
| 
 | 
 | ||||||
|  |    # Ensure that the error is not raised for invalid expressions | ||||||
|  | 
 | ||||||
|  |    >>> {1: 2, 3: foo(,), 4: 5} | ||||||
|  |    Traceback (most recent call last): | ||||||
|  |    SyntaxError: invalid syntax | ||||||
|  | 
 | ||||||
|  |    >>> {1: $, 2: 3} | ||||||
|  |    Traceback (most recent call last): | ||||||
|  |    SyntaxError: invalid syntax | ||||||
|  | 
 | ||||||
| Specialized indentation errors: | Specialized indentation errors: | ||||||
| 
 | 
 | ||||||
|    >>> while condition: |    >>> while condition: | ||||||
|  |  | ||||||
|  | @ -0,0 +1 @@ | ||||||
|  | Fix error for dictionary literals with invalid expression as value. | ||||||
							
								
								
									
										959
									
								
								Parser/parser.c
									
										
									
										generated
									
									
									
								
							
							
						
						
									
										959
									
								
								Parser/parser.c
									
										
									
										generated
									
									
									
								
							
										
											
												File diff suppressed because it is too large
												Load diff
											
										
									
								
							
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Miss Islington (bot)
						Miss Islington (bot)