mirror of
				https://github.com/python/cpython.git
				synced 2025-11-03 23:21:29 +00:00 
			
		
		
		
	bpo-29970: Make ssh_handshake_timeout None by default (#4939)
* Make ssh_handshake_timeout None by default. * Raise ValueError if ssl_handshake_timeout is used without ssl. * Raise ValueError if ssl_handshake_timeout is not positive.
This commit is contained in:
		
							parent
							
								
									a7a751dd7b
								
							
						
					
					
						commit
						51eb1c6b9c
					
				
					 10 changed files with 108 additions and 21 deletions
				
			
		| 
						 | 
				
			
			@ -402,10 +402,17 @@ class SSLProtocol(protocols.Protocol):
 | 
			
		|||
    def __init__(self, loop, app_protocol, sslcontext, waiter,
 | 
			
		||||
                 server_side=False, server_hostname=None,
 | 
			
		||||
                 call_connection_made=True,
 | 
			
		||||
                 ssl_handshake_timeout=constants.SSL_HANDSHAKE_TIMEOUT):
 | 
			
		||||
                 ssl_handshake_timeout=None):
 | 
			
		||||
        if ssl is None:
 | 
			
		||||
            raise RuntimeError('stdlib ssl module not available')
 | 
			
		||||
 | 
			
		||||
        if ssl_handshake_timeout is None:
 | 
			
		||||
            ssl_handshake_timeout = constants.SSL_HANDSHAKE_TIMEOUT
 | 
			
		||||
        elif ssl_handshake_timeout <= 0:
 | 
			
		||||
            raise ValueError(
 | 
			
		||||
                f"ssl_handshake_timeout should be a positive number, "
 | 
			
		||||
                f"got {ssl_handshake_timeout}")
 | 
			
		||||
 | 
			
		||||
        if not sslcontext:
 | 
			
		||||
            sslcontext = _create_transport_context(
 | 
			
		||||
                server_side, server_hostname)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue