diff --git a/Lib/ssl.py b/Lib/ssl.py index b1cc149d87e..e0096971640 100644 --- a/Lib/ssl.py +++ b/Lib/ssl.py @@ -240,16 +240,9 @@ def recv(self, buflen=1024, flags=0): if self._sslobj: if flags != 0: raise ValueError( - "non-zero flags not allowed in calls to recv_into() on %s" % - self.__class__) - while True: - try: - return self.read(buflen) - except SSLError as x: - if x.args[0] == SSL_ERROR_WANT_READ: - continue - else: - raise x + "non-zero flags not allowed in calls to recv() on %s" % + self.__class__) + return self.read(buflen) else: return socket.recv(self, buflen, flags) @@ -273,6 +266,7 @@ def recv_into(self, buffer, nbytes=None, flags=0): continue else: raise x + return self.read(nbytes, buffer) else: return socket.recv_into(self, buffer, nbytes, flags) diff --git a/Lib/test/test_ftplib.py b/Lib/test/test_ftplib.py index 2ed1e5f2d74..29f7f7d84bc 100644 --- a/Lib/test/test_ftplib.py +++ b/Lib/test/test_ftplib.py @@ -296,7 +296,9 @@ def send(self, data): try: return super(SSLConnection, self).send(data) except ssl.SSLError as err: - if err.args[0] in (ssl.SSL_ERROR_EOF, ssl.SSL_ERROR_ZERO_RETURN): + if err.args[0] in (ssl.SSL_ERROR_EOF, ssl.SSL_ERROR_ZERO_RETURN, + ssl.SSL_ERROR_WANT_READ, + ssl.SSL_ERROR_WANT_WRITE): return 0 raise @@ -304,6 +306,9 @@ def recv(self, buffer_size): try: return super(SSLConnection, self).recv(buffer_size) except ssl.SSLError as err: + if err.args[0] in (ssl.SSL_ERROR_WANT_READ, + ssl.SSL_ERROR_WANT_WRITE): + return '' if err.args[0] in (ssl.SSL_ERROR_EOF, ssl.SSL_ERROR_ZERO_RETURN): self.handle_close() return b'' diff --git a/Misc/NEWS b/Misc/NEWS index 8a62cbf4a29..a27dd11f92b 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -287,6 +287,8 @@ C-API Library ------- +- Issue #3890: Fix recv() and recv_into() on non-blocking SSL sockets. + - Issue #4282: Fix the main function of the profile module for a non-ASCII script, open the file in binary mode and not in text mode with the default (utf8) encoding.