Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-04-20 10:51:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-146393: Use recorded type instead of instance in BINARY_OP (#148569)

Browse source
This commit is contained in:
Pieter Eendebak 2026-04-14 22:11:42 +02:00 • committed by GitHub
parent 0012686d92
commit 5c3decad66
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 1042 additions and 1013 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Python/optimizer_bytecodes.c
View file

@ -294,10 +294,10 @@ dummy_func(void) {
bool is_remainder = (oparg == NB_REMAINDER
|| oparg == NB_INPLACE_REMAINDER);
// Promote probable-float operands to known floats via speculative
// guards. _RECORD_TOS / _RECORD_NOS in the BINARY_OP macro record
// the observed operand during tracing, which sym_get_probable_type
// reads here. Applied only to ops where narrowing unlocks a
// meaningful downstream win:
// guards. _RECORD_TOS_TYPE / _RECORD_NOS_TYPE in the BINARY_OP macro
// record the observed operand type during tracing, which
// sym_get_probable_type reads here. Applied only to ops where
// narrowing unlocks a meaningful downstream win:
// - NB_TRUE_DIVIDE: enables the specialized float path below.
// - NB_REMAINDER: lets the float result type propagate.
// NB_POWER is excluded — speculative guards there regressed
@ -2424,6 +2424,11 @@ dummy_func(void) {
sym_set_recorded_value(nos, (PyObject *)this_instr->operand0);
}
op(_RECORD_NOS_TYPE, (nos, tos -- nos, tos)) {
PyTypeObject *tp = (PyTypeObject *)this_instr->operand0;
sym_set_recorded_type(nos, tp);
}
op(_RECORD_4OS, (value, _3os, nos, tos -- value, _3os, nos, tos)) {
sym_set_recorded_value(value, (PyObject *)this_instr->operand0);
}