mirror of
https://github.com/python/cpython.git
synced 2026-04-22 03:41:08 +00:00
bpo-34279: regrtest consider that skipped tests are ran (GH-11132)
bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fef4a)
Co-authored-by: Victor Stinner <vstinner@redhat.com>
This commit is contained in:
parent
527008599d
commit
5f252e1ebc
3 changed files with 18 additions and 1 deletions
|
|
@ -1897,7 +1897,7 @@ def _run_suite(suite):
|
|||
if junit_xml_list is not None:
|
||||
junit_xml_list.append(result.get_xml_element())
|
||||
|
||||
if not result.testsRun:
|
||||
if not result.testsRun and not result.skipped:
|
||||
raise TestDidNotRun
|
||||
if not result.wasSuccessful():
|
||||
if len(result.errors) == 1 and not result.failures:
|
||||
|
|
|
|||
|
|
@ -1004,6 +1004,7 @@ def test_bug(self):
|
|||
output = self.run_tests("-w", testname, exitcode=2)
|
||||
self.check_executed_tests(output, [testname],
|
||||
failed=testname, rerun=testname)
|
||||
|
||||
def test_no_tests_ran(self):
|
||||
code = textwrap.dedent("""
|
||||
import unittest
|
||||
|
|
@ -1017,6 +1018,19 @@ def test_bug(self):
|
|||
output = self.run_tests(testname, "-m", "nosuchtest", exitcode=0)
|
||||
self.check_executed_tests(output, [testname], no_test_ran=testname)
|
||||
|
||||
def test_no_tests_ran_skip(self):
|
||||
code = textwrap.dedent("""
|
||||
import unittest
|
||||
|
||||
class Tests(unittest.TestCase):
|
||||
def test_skipped(self):
|
||||
self.skipTest("because")
|
||||
""")
|
||||
testname = self.create_test(code=code)
|
||||
|
||||
output = self.run_tests(testname, exitcode=0)
|
||||
self.check_executed_tests(output, [testname])
|
||||
|
||||
def test_no_tests_ran_multiple_tests_nonexistent(self):
|
||||
code = textwrap.dedent("""
|
||||
import unittest
|
||||
|
|
|
|||
|
|
@ -0,0 +1,3 @@
|
|||
:func:`test.support.run_unittest` no longer raise :exc:`TestDidNotRun` if
|
||||
the test result contains skipped tests. The exception is now only raised if
|
||||
no test have been run and no test have been skipped.
|
||||
Loading…
Add table
Add a link
Reference in a new issue