Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-01-06 15:32:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-32892: Support subclasses of base types in isinstance checks for AST constants. (GH-9934)

Browse source 
Some projects (e.g. Chameleon) create ast.Str containing an instance
of the str subclass.
This commit is contained in:
Serhiy Storchaka 2018-10-28 13:43:03 +02:00 • committed by GitHub
parent 913876d824
commit 6015cc50bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/ast.py
View file

@ -346,7 +346,7 @@ def __instancecheck__(cls, inst):
except AttributeError:
return False
else:
return type(value) in _const_types[cls]
return isinstance(value, _const_types[cls])
return type.__instancecheck__(cls, inst)
def _new(cls, *args, **kwargs):

4
Lib/test/test_ast.py
View file

@ -399,6 +399,10 @@ def test_isinstance(self):
self.assertFalse(isinstance(ast.Constant(), ast.NameConstant))
self.assertFalse(isinstance(ast.Constant(), ast.Ellipsis))
class S(str): pass
self.assertTrue(isinstance(ast.Constant(S('42')), ast.Str))
self.assertFalse(isinstance(ast.Constant(S('42')), ast.Num))
def test_subclasses(self):
class N(ast.Num):
def __init__(self, *args, **kwargs):