Having CFLAGS come before OPT prevents silencing certain classes of warnings

from the fact that OPT contains -Wall be default. This is annoying when
compilers like clang have thorough debugging information about things that
Python does extensively (e.g. -Wunused-value for unused return values caused by
a macro use).
This commit is contained in:
Brett Cannon 2010-06-26 22:29:06 +00:00
parent 1341f57c9f
commit 620c6c760d
2 changed files with 3 additions and 1 deletions

View file

@ -59,7 +59,7 @@ MAKESETUP= $(srcdir)/Modules/makesetup
# Compiler options
OPT= @OPT@
BASECFLAGS= @BASECFLAGS@
CFLAGS= $(BASECFLAGS) @CFLAGS@ $(OPT) $(EXTRA_CFLAGS)
CFLAGS= $(BASECFLAGS) $(OPT) @CFLAGS@ $(EXTRA_CFLAGS)
# Both CPPFLAGS and LDFLAGS need to contain the shell's value for setup.py to
# be able to build extension modules using the directories specified in the
# environment variables

View file

@ -1461,6 +1461,8 @@ Extension Modules
Build
-----
- Have CFLAGS come after OPT to allow for overriding warnings flags.
- Issue #8854: Fix finding Visual Studio 2008 on Windows x64.
- Issue #1759169, #8864: Drop _XOPEN_SOURCE on Solaris, define it for