Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-140210: Make test_sysconfig.test_parse_makefile_renamed_vars ignore environment variables (#140213)

Browse source 
The test did not expect it could be run with e.g. CFLAGS set to a custom value.
This commit is contained in:
Miro Hrončok 2025-11-27 19:00:02 +01:00 • committed by GitHub
parent e02801dc37
commit 69f54ce452
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/test/test_sysconfig.py
View file

@ -20,7 +20,7 @@
) )
from test.support.import_helper import import_module from test.support.import_helper import import_module
from test.support.os_helper import (TESTFN, unlink, skip_unless_symlink, from test.support.os_helper import (TESTFN, unlink, skip_unless_symlink,
change_cwd) change_cwd, EnvironmentVarGuard)
from test.support.venv import VirtualEnvironmentMixin from test.support.venv import VirtualEnvironmentMixin
import sysconfig import sysconfig
@ -807,7 +807,9 @@ def test_parse_makefile_renamed_vars(self):
print("PY_LDFLAGS=-lm", file=makefile) print("PY_LDFLAGS=-lm", file=makefile)
print("var2=$(LDFLAGS)", file=makefile) print("var2=$(LDFLAGS)", file=makefile)
print("var3=$(CPPFLAGS)", file=makefile) print("var3=$(CPPFLAGS)", file=makefile)
vars = _parse_makefile(TESTFN) with EnvironmentVarGuard() as env:
env.clear()
vars = _parse_makefile(TESTFN)
self.assertEqual(vars, { self.assertEqual(vars, {
'var1': '-Wall', 'var1': '-Wall',
'CFLAGS': '-Wall', 'CFLAGS': '-Wall',

2
Misc/NEWS.d/next/Tests/2025-10-16-15-08-58.gh-issue-140210.P9vUP8.rst Normal file
View file

@ -0,0 +1,2 @@
Make ``test_sysconfig.test_parse_makefile_renamed_vars`` less fragile by
clearing the environment variables before parsing the Makefile.