Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-24 02:13:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-113343: Fix error check on mmap(2) (#113342)

Browse source 
Fix error check on mmap(2)

It should check MAP_FAILED instead of NULL for error.

On mmap(2) man page:

  RETURN VALUE
       On success, mmap() returns a pointer to the mapped area.
       On error, the value MAP_FAILED (that is, (void *) -1) is
       returned, and errno is set to indicate the error.
This commit is contained in:
Namhyung Kim 2023-12-21 11:28:55 -08:00 • committed by GitHub
parent 5f7a80fd02
commit 6b70c3dc5a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Python/perf_trampoline.c
View file

@ -247,7 +247,7 @@ new_code_arena(void)
mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS,
-1, // fd (not used here) -1, // fd (not used here)
0); // offset (not used here) 0); // offset (not used here)
if (!memory) { if (memory == MAP_FAILED) {
PyErr_SetFromErrno(PyExc_OSError); PyErr_SetFromErrno(PyExc_OSError);
PyErr_FormatUnraisable("Failed to create new mmap for perf trampoline"); PyErr_FormatUnraisable("Failed to create new mmap for perf trampoline");
perf_status = PERF_STATUS_FAILED; perf_status = PERF_STATUS_FAILED;