Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 15:11:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

GH-89727: Fix pathlib.Path.walk RecursionError on deep trees (GH-100282)

Browse source 
Use a stack to implement `pathlib.Path.walk()` iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees.

Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Brett Cannon <brett@python.org>
This commit is contained in:
Stanislav Zmiev 2023-03-22 18:45:25 +04:00 • committed by GitHub
parent af9c34f6ef
commit 713df2c534
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 49 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Lib/test/test_pathlib.py
View file

@ -13,6 +13,7 @@
from unittest import mock
from test.support import import_helper
from test.support import set_recursion_limit
from test.support import is_emscripten, is_wasi
from test.support import os_helper
from test.support.os_helper import TESTFN, FakePath
@ -2793,6 +2794,18 @@ def test_walk_many_open_files(self):
self.assertEqual(next(it), expected)
path = path / 'd'
def test_walk_above_recursion_limit(self):
recursion_limit = 40
# directory_depth > recursion_limit
directory_depth = recursion_limit + 10
base = pathlib.Path(os_helper.TESTFN, 'deep')
path = pathlib.Path(base, *(['d'] * directory_depth))
path.mkdir(parents=True)
with set_recursion_limit(recursion_limit):
list(base.walk())
list(base.walk(top_down=False))
class PathTest(_BasePathTest, unittest.TestCase):
cls = pathlib.Path