Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-27 03:34:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix IndexError when parsing unexpectedly ending quoted-string. (GH-14813)

Browse source 
This exception was caused because the input ended unexpectedly with only one
single quote instead of a pair with some value inside it.
This commit is contained in:
Abhilash Raj 2019-07-17 09:48:52 -07:00 • committed by Barry Warsaw
parent a4a994bd3e
commit 719a062bcb
3 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/email/_header_value_parser.py
View file

@ -1191,7 +1191,7 @@ def get_bare_quoted_string(value):
"expected '\"' but found '{}'".format(value)) "expected '\"' but found '{}'".format(value))
bare_quoted_string = BareQuotedString() bare_quoted_string = BareQuotedString()
value = value[1:] value = value[1:]
if value[0] == '"': if value and value[0] == '"':
token, value = get_qcontent(value) token, value = get_qcontent(value)
bare_quoted_string.append(token) bare_quoted_string.append(token)
while value and value[0] != '"': while value and value[0] != '"':

4
Lib/test/test_email/test__header_value_parser.py
View file

@ -522,6 +522,10 @@ def test_get_bare_quoted_string_only_quotes(self):
self._test_get_x(parser.get_bare_quoted_string, self._test_get_x(parser.get_bare_quoted_string,
'""', '""', '', [], '') '""', '""', '', [], '')
def test_get_bare_quoted_string_missing_endquotes(self):
self._test_get_x(parser.get_bare_quoted_string,
'"', '""', '', [errors.InvalidHeaderDefect], '')
def test_get_bare_quoted_string_following_wsp_preserved(self): def test_get_bare_quoted_string_following_wsp_preserved(self):
self._test_get_x(parser.get_bare_quoted_string, self._test_get_x(parser.get_bare_quoted_string,
'"foo"\t bar', '"foo"', 'foo', [], '\t bar') '"foo"\t bar', '"foo"', 'foo', [], '\t bar')

2
Misc/NEWS.d/next/Library/2019-07-17-06-54-43.bpo-37491.op0aMs.rst Normal file
View file

@ -0,0 +1,2 @@
Fix ``IndexError`` when parsing email headers with unexpectedly ending
bare-quoted string value. Patch by Abhilash Raj.