Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-03-06 13:00:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-33674: asyncio: Fix SSLProtocol race (GH-7175) (GH-7188)

Browse source 
Fix a race condition in SSLProtocol.connection_made() of
asyncio.sslproto: start immediately the handshake instead of using
call_soon(). Previously, data_received() could be called before the
handshake started, causing the handshake to hang or fail.

(cherry picked from commit be00a5583a)
This commit is contained in:
Victor Stinner 2018-05-29 06:46:48 +02:00 • committed by Yury Selivanov
parent 325320d5f5
commit 7593b8a507
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/asyncio/sslproto.py
View file

@ -574,7 +574,7 @@ def _start_handshake(self):
# (b'', 1) is a special value in _process_write_backlog() to do
# the SSL handshake
self._write_backlog.append((b'', 1))
self._loop.call_soon(self._process_write_backlog)
self._process_write_backlog()
def _on_handshake_complete(self, handshake_exc):
self._in_handshake = False

4
Misc/NEWS.d/next/Library/2018-05-28-22-49-59.bpo-33674.6LFFj7.rst Normal file
View file

@ -0,0 +1,4 @@
Fix a race condition in SSLProtocol.connection_made() of asyncio.sslproto:
start immediately the handshake instead of using call_soon(). Previously,
data_received() could be called before the handshake started, causing the
handshake to hang or fail.