diff --git a/Misc/NEWS b/Misc/NEWS index 5438245ba4c..e6948d70e21 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -132,6 +132,9 @@ Core and Builtins Library ------- +- Issue #16305: Fix a segmentation fault occurring when interrupting + math.factorial. + - Issue #14398: Fix size truncation and overflow bugs in the bz2 module. - Issue #16220: wsgiref now always calls close() on an iterable response. diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c index 2c4cc7331b7..142eca468a2 100644 --- a/Modules/mathmodule.c +++ b/Modules/mathmodule.c @@ -1330,14 +1330,13 @@ factorial_odd_part(unsigned long n) Py_DECREF(outer); outer = tmp; } - - goto done; + Py_DECREF(inner); + return outer; error: Py_DECREF(outer); - done: Py_DECREF(inner); - return outer; + return NULL; } /* Lookup table for small factorial values */