diff --git a/Lib/crypt.py b/Lib/crypt.py index b90c81cc40e..49ab96e1400 100644 --- a/Lib/crypt.py +++ b/Lib/crypt.py @@ -28,7 +28,7 @@ def mksalt(method=None): if method is None: method = methods[0] s = '${}$'.format(method.ident) if method.ident else '' - s += ''.join(_sr.sample(_saltchars, method.salt_chars)) + s += ''.join(_sr.choice(_saltchars) for char in range(method.salt_chars)) return s diff --git a/Misc/NEWS b/Misc/NEWS index b37bf3addec..7a4491aa3a8 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -66,6 +66,8 @@ Core and Builtins Library ------- +- Issue #18405: Improve the entropy of crypt.mksalt(). + - Issue #18676: Change 'positive' to 'non-negative' in queue.py put and get docstrings and ValueError messages. Patch by Zhongyue Luo