mirror of
https://github.com/python/cpython.git
synced 2025-12-08 06:10:17 +00:00
Fix and optimize test code
This commit is contained in:
parent
5453dbc0a6
commit
80ab2e27e4
1 changed files with 3 additions and 15 deletions
|
|
@ -1704,17 +1704,13 @@ def test_repack_bytes_before_first_file(self):
|
|||
# calculate the expected results
|
||||
_test_files = [data for j, data in enumerate(test_files) if j not in ii]
|
||||
with open(TESTFN, 'wb') as fh:
|
||||
fh.write(b'dummy')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
fh.write(b'dummy ')
|
||||
expected_zinfos = self._prepare_zip_from_test_files(fh, _test_files)
|
||||
expected_size = os.path.getsize(TESTFN)
|
||||
|
||||
# do the removal and check the result
|
||||
with open(TESTFN, 'wb') as fh:
|
||||
fh.write(b'dummy')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
fh.write(b'dummy ')
|
||||
zinfos = self._prepare_zip_from_test_files(fh, test_files)
|
||||
with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh:
|
||||
for i in ii:
|
||||
|
|
@ -1748,16 +1744,12 @@ def test_repack_magic_before_first_file(self):
|
|||
_test_files = [data for j, data in enumerate(test_files) if j not in ii]
|
||||
with open(TESTFN, 'wb') as fh:
|
||||
fh.write(b'PK\003\004 ')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
expected_zinfos = self._prepare_zip_from_test_files(fh, _test_files)
|
||||
expected_size = os.path.getsize(TESTFN)
|
||||
|
||||
# do the removal and check the result
|
||||
with open(TESTFN, 'wb') as fh:
|
||||
fh.write(b'PK\003\004 ')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
zinfos = self._prepare_zip_from_test_files(fh, test_files)
|
||||
with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh:
|
||||
for i in ii:
|
||||
|
|
@ -1777,7 +1769,7 @@ def test_repack_magic_before_first_file(self):
|
|||
self.assertEqual(os.path.getsize(TESTFN), expected_size)
|
||||
|
||||
def test_repack_file_entry_before_first_file(self):
|
||||
"""Should preserve seeming valid file entries not forming consecutive
|
||||
"""Should preserve seemingly valid file entries not forming consecutive
|
||||
valid file entries until the first recorded local file entry.
|
||||
|
||||
This may happen whan a self-extractor contains an uncompressed ZIP
|
||||
|
|
@ -1797,8 +1789,6 @@ def test_repack_file_entry_before_first_file(self):
|
|||
with zipfile.ZipFile(fh, 'w') as zh:
|
||||
zh.writestr('file.txt', b'dummy')
|
||||
fh.write(b' ')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
expected_zinfos = self._prepare_zip_from_test_files(fh, _test_files)
|
||||
expected_size = os.path.getsize(TESTFN)
|
||||
|
||||
|
|
@ -1807,8 +1797,6 @@ def test_repack_file_entry_before_first_file(self):
|
|||
with zipfile.ZipFile(fh, 'w') as zh:
|
||||
zh.writestr('file.txt', b'dummy')
|
||||
fh.write(b' ')
|
||||
with open(TESTFN, 'r+b') as fh:
|
||||
fh.seek(0, 2)
|
||||
zinfos = self._prepare_zip_from_test_files(fh, test_files)
|
||||
with zipfile.ZipFile(TESTFN, 'a', self.compression) as zh:
|
||||
for i in ii:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue