Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-31 04:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-138736: Fix sqlite3.Connection.blobopen 'row' parameter type and naming (#138738)

Browse source 
The 'row' parameter represents a ROWID. Clarify this in docs and docstrings.
This commit is contained in:
chiri 2025-09-17 18:51:14 +03:00 • committed by GitHub
parent 77a22ef76a
commit 8eb106240f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Doc/library/sqlite3.rst
View file

@ -620,7 +620,7 @@ Connection objects
supplied, this must be a :term:`callable` returning
an instance of :class:`Cursor` or its subclasses.
.. method:: blobopen(table, column, row, /, *, readonly=False, name="main")
.. method:: blobopen(table, column, rowid, /, *, readonly=False, name="main")
Open a :class:`Blob` handle to an existing
:abbr:`BLOB (Binary Large OBject)`.
@ -631,8 +631,8 @@ Connection objects
:param str column:
The name of the column where the blob is located.
:param str row:
The name of the row where the blob is located.
:param int rowid:
The row id where the blob is located.
:param bool readonly:
Set to ``True`` if the blob should be opened without write

8
Modules/_sqlite/clinic/connection.c.h generated
View file

@ -209,7 +209,7 @@ exit:
}
PyDoc_STRVAR(blobopen__doc__,
"blobopen($self, table, column, row, /, *, readonly=False, name=\'main\')\n"
"blobopen($self, table, column, rowid, /, *, readonly=False, name=\'main\')\n"
"--\n"
"\n"
"Open and return a BLOB object.\n"
@ -218,8 +218,8 @@ PyDoc_STRVAR(blobopen__doc__,
" Table name.\n"
" column\n"
" Column name.\n"
" row\n"
" Row index.\n"
" rowid\n"
" Row id.\n"
" readonly\n"
" Open the BLOB without write permissions.\n"
" name\n"
@ -1722,4 +1722,4 @@ exit:
#ifndef DESERIALIZE_METHODDEF
#define DESERIALIZE_METHODDEF
#endif /* !defined(DESERIALIZE_METHODDEF) */
/*[clinic end generated code: output=6cb96e557133d553 input=a9049054013a1b77]*/
/*[clinic end generated code: output=16d44c1d8a45e622 input=a9049054013a1b77]*/

6
Modules/_sqlite/connection.c
View file

@ -578,8 +578,8 @@ _sqlite3.Connection.blobopen as blobopen
Table name.
column as col: str
Column name.
row: sqlite3_int64
Row index.
rowid as row: sqlite3_int64
Row id.
/
*
readonly: bool = False
@ -593,7 +593,7 @@ Open and return a BLOB object.
static PyObject *
blobopen_impl(pysqlite_Connection *self, const char *table, const char *col,
sqlite3_int64 row, int readonly, const char *name)
/*[clinic end generated code: output=6a02d43efb885d1c input=23576bd1108d8774]*/
/*[clinic end generated code: output=6a02d43efb885d1c input=cc3d4b47dac08401]*/
{
if (!pysqlite_check_thread(self) || !pysqlite_check_connection(self)) {
return NULL;