mirror of
https://github.com/python/cpython.git
synced 2025-12-31 04:23:37 +00:00
[3.11] gh-112305: Fix check-clean-src to detect frozen_modules .h files. (GH-113344) (#113347)
gh-112305: Fix check-clean-src to detect frozen_modules .h files. (GH-113344)
A typo left this check broken so many of us who do out-of-tree builds
were seeing strange failures due to bad `Python/frozen_modules/*.h`
files being picked up from the source tree and used at build time from
different Python versions leading to errors like:
`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`
Or similar once our build got to an "invoke the interpreter"
bootstrapping step due to incorrect bytecode being embedded.
(cherry picked from commit 103c4ea274)
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This commit is contained in:
parent
9cbe4738bc
commit
90593e6fa1
2 changed files with 7 additions and 2 deletions
|
|
@ -594,11 +594,13 @@ check-clean-src:
|
|||
@if test -n "$(VPATH)" -a \( \
|
||||
-f "$(srcdir)/$(BUILDPYTHON)" \
|
||||
-o -f "$(srcdir)/Programs/python.o" \
|
||||
-o -f "$(srcdir)\Python/frozen_modules/importlib._bootstrap.h" \
|
||||
-o -f "$(srcdir)/Python/frozen_modules/importlib._bootstrap.h" \
|
||||
\); then \
|
||||
echo "Error: The source directory ($(srcdir)) is not clean" ; \
|
||||
echo "Building Python out of the source tree (in $(abs_builddir)) requires a clean source tree ($(abs_srcdir))" ; \
|
||||
echo "Try to run: make -C \"$(srcdir)\" clean" ; \
|
||||
echo "Build artifacts such as .o files, executables, and Python/frozen_modules/*.h must not exist within $(srcdir)." ; \
|
||||
echo "Try to run:" ; \
|
||||
echo " (cd \"$(srcdir)\" && make clean || git clean -fdx -e Doc/venv)" ; \
|
||||
exit 1; \
|
||||
fi
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue