Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-12 03:22:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-76912: Raise OSError from any failure in getpass.getuser() (#29739)

Browse source 
* bpo-32731: Raise OSError from any failure in getpass.getuser()
Previously, if the username was not set in certain environment variables, ImportError escaped on Windows systems, and it was possible for KeyError to escape on other systems if getpwuid() failed.
This commit is contained in:
Jacob Walls 2023-11-27 13:05:55 -05:00 • committed by GitHub
parent 936c503a44
commit 99a73c3465
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 24 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/test_getpass.py
View file

@ -26,7 +26,7 @@ def test_username_priorities_of_env_values(self, environ):
environ.get.return_value = None
try:
getpass.getuser()
except ImportError: # in case there's no pwd module
except OSError: # in case there's no pwd module
pass
except KeyError:
# current user has no pwd entry
@ -47,7 +47,7 @@ def test_username_falls_back_to_pwd(self, environ):
getpass.getuser())
getpw.assert_called_once_with(42)
else:
self.assertRaises(ImportError, getpass.getuser)
self.assertRaises(OSError, getpass.getuser)
class GetpassRawinputTest(unittest.TestCase):