Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-31 04:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-93884: Improve test coverage of PyNumber_ToBase (GH-93932)

Browse source 
Link to #93884 
* Test with some large negative and positive values(out of range of a longlong,i.e.[-2\*\*63, 2\*\*63-1])
* Test with objects of non-int type

Automerge-Triggered-By: GH:mdickinson
This commit is contained in:
Charlie Zhao 2022-09-04 18:37:04 +08:00 • committed by GitHub
parent 69bb83c2bf
commit 9b9394df5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Lib/test/test_capi.py
View file

@ -753,14 +753,30 @@ def meth(self):
def test_pynumber_tobase(self):
from _testcapi import pynumber_tobase
self.assertEqual(pynumber_tobase(123, 2), '0b1111011')
self.assertEqual(pynumber_tobase(123, 8), '0o173')
self.assertEqual(pynumber_tobase(123, 10), '123')
self.assertEqual(pynumber_tobase(123, 16), '0x7b')
self.assertEqual(pynumber_tobase(-123, 2), '-0b1111011')
self.assertEqual(pynumber_tobase(-123, 8), '-0o173')
self.assertEqual(pynumber_tobase(-123, 10), '-123')
self.assertEqual(pynumber_tobase(-123, 16), '-0x7b')
small_number = 123
large_number = 2**64
class IDX:
def __init__(self, val):
self.val = val
def __index__(self):
return self.val
test_cases = ((2, '0b1111011', '0b10000000000000000000000000000000000000000000000000000000000000000'),
(8, '0o173', '0o2000000000000000000000'),
(10, '123', '18446744073709551616'),
(16, '0x7b', '0x10000000000000000'))
for base, small_target, large_target in test_cases:
with self.subTest(base=base, st=small_target, lt=large_target):
# Test for small number
self.assertEqual(pynumber_tobase(small_number, base), small_target)
self.assertEqual(pynumber_tobase(-small_number, base), '-' + small_target)
self.assertEqual(pynumber_tobase(IDX(small_number), base), small_target)
# Test for large number(out of range of a longlong,i.e.[-2**63, 2**63-1])
self.assertEqual(pynumber_tobase(large_number, base), large_target)
self.assertEqual(pynumber_tobase(-large_number, base), '-' + large_target)
self.assertEqual(pynumber_tobase(IDX(large_number), base), large_target)
self.assertRaises(TypeError, pynumber_tobase, IDX(123.0), 10)
self.assertRaises(TypeError, pynumber_tobase, IDX('123'), 10)
self.assertRaises(TypeError, pynumber_tobase, 123.0, 10)
self.assertRaises(TypeError, pynumber_tobase, '123', 10)
self.assertRaises(SystemError, pynumber_tobase, 123, 0)

1
Misc/NEWS.d/next/Tests/2022-06-17-13-27-21.gh-issue-93884.5pvPvl.rst Normal file
View file

@ -0,0 +1 @@
Add test cases for :c:func:`PyNumber_ToBase` that take a large number or a non-int object as parameter.