bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)

Added missing .grab_release() calls to all places where we call .grab_set().
(cherry picked from commit 10ea9409ce)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
This commit is contained in:
Miss Islington (bot) 2018-08-02 00:14:24 -07:00 committed by GitHub
parent 6f16ffc187
commit 9fcfb7b010
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 0 deletions

View file

@ -235,10 +235,12 @@ def OK(self, event=None):
return
if (self.advanced or self.KeysOK(keys)) and self.bind_ok(keys):
self.result = keys
self.grab_release()
self.destroy()
def Cancel(self, event=None):
self.result=''
self.grab_release()
self.destroy()
def KeysOK(self, keys):

View file

@ -191,6 +191,7 @@ def cancel(self):
def destroy(self):
global font_sample_text
font_sample_text = self.fontpage.font_sample.get('1.0', 'end')
self.grab_release()
super().destroy()
def help(self):

View file

@ -195,6 +195,7 @@ def display_file_text(self, title, filename, encoding=None):
def ok(self, event=None):
"Dismiss help_about dialog."
self.grab_release()
self.destroy()

View file

@ -143,6 +143,10 @@ def cancel(self, event=None): # Do not replace.
self.result = None
self.destroy()
def destroy(self):
self.grab_release()
super().destroy()
class SectionName(Query):
"Get a name for a config file section name."

View file

@ -91,6 +91,7 @@ def __init__(self, parent, title, text, modal=True,
def ok(self, event=None):
"""Dismiss text viewer dialog."""
self.grab_release()
self.destroy()

View file

@ -0,0 +1 @@
Fix unresponsiveness after closing certain windows and dialogs.