[3.13] gh-148370: prevent quadratic behavior in configparser.ParsingError.combine (GH-148452) (#148533)

gh-148370: prevent quadratic behavior in `configparser.ParsingError.combine` (GH-148452)
(cherry picked from commit 2662db0c45)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This commit is contained in:
Miss Islington (bot) 2026-04-14 01:05:38 +02:00 committed by GitHub
parent d82c491b2e
commit a69b14bc01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 21 additions and 3 deletions

View file

@ -316,12 +316,15 @@ def __init__(self, source, *args):
def append(self, lineno, line):
self.errors.append((lineno, line))
self.message += '\n\t[line %2d]: %s' % (lineno, repr(line))
self.message += f'\n\t[line {lineno:2d}]: {line!r}'
def combine(self, others):
messages = [self.message]
for other in others:
for error in other.errors:
self.append(*error)
for lineno, line in other.errors:
self.errors.append((lineno, line))
messages.append(f'\n\t[line {lineno:2d}]: {line!r}')
self.message = "".join(messages)
return self
@staticmethod

View file

@ -1729,6 +1729,19 @@ def test_error(self):
self.assertEqual(e1.message, e2.message)
self.assertEqual(repr(e1), repr(e2))
def test_combine_error_linear_complexity(self):
# Ensure that ParsingError.combine() has linear complexity.
# See https://github.com/python/cpython/issues/148370.
n = 50000
s = '[*]\n' + (err_line := '=\n') * n
p = configparser.ConfigParser(strict=False)
with self.assertRaises(configparser.ParsingError) as cm:
p.read_string(s)
errlines = cm.exception.message.splitlines()
self.assertEqual(len(errlines), n + 1)
self.assertTrue(errlines[0].startswith("Source contains parsing errors: "))
self.assertEqual(errlines[42], f"\t[line {43:2d}]: {err_line!r}")
def test_nosectionerror(self):
import pickle
e1 = configparser.NoSectionError('section')

View file

@ -0,0 +1,2 @@
:mod:`configparser`: prevent quadratic behavior when a :exc:`~configparser.ParsingError`
is raised after a parser fails to parse multiple lines. Patch by Bénédikt Tran.