Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-31 04:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-131038: Use text=True in subprocesses in test_perf_profiler (#137117)

Browse source
This commit is contained in:
Pablo Galindo Salgado 2025-07-26 18:01:51 +01:00 • committed by GitHub
parent d5fa437dfb
commit a852c7bdd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_perf_profiler.py
View file

@ -318,6 +318,7 @@ def run_perf(cwd, *args, use_jit=False, **env_vars):
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
env=env,
text=True,
)
if proc.returncode:
print(proc.stderr, file=sys.stderr)
@ -327,10 +328,10 @@ def run_perf(cwd, *args, use_jit=False, **env_vars):
jit_output_file = cwd + "/jit_output.dump"
command = ("perf", "inject", "-j", "-i", output_file, "-o", jit_output_file)
proc = subprocess.run(
command, stderr=subprocess.PIPE, stdout=subprocess.PIPE, env=env
command, stderr=subprocess.PIPE, stdout=subprocess.PIPE, env=env, text=True
)
if proc.returncode:
print(proc.stderr)
print(proc.stderr, file=sys.stderr)
raise ValueError(f"Perf failed with return code {proc.returncode}")
# Copy the jit_output_file to the output_file
os.rename(jit_output_file, output_file)
@ -342,10 +343,9 @@ def run_perf(cwd, *args, use_jit=False, **env_vars):
stderr=subprocess.PIPE,
env=env,
check=True,
text=True,
)
return proc.stdout.decode("utf-8", "replace"), proc.stderr.decode(
"utf-8", "replace"
)
return proc.stdout, proc.stderr
class TestPerfProfilerMixin: