Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-31 05:31:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-26133: Fix typos (#5010)

Browse source 
* Fix typos
* Change warning text
* Add test
This commit is contained in:
Andrew Svetlov 2017-12-26 11:53:38 +02:00 • committed by GitHub
parent e0aef4f3cd
commit a8f4e15f3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/asyncio/unix_events.py
View file

@ -56,9 +56,9 @@ def close(self):
self.remove_signal_handler(sig) self.remove_signal_handler(sig)
else: else:
if self._signal_handlers: if self._signal_handlers:
warinigs.warn(f"Closing the loop {self!r} " warnings.warn(f"Closing the loop {self!r} "
f"on interpreter shutdown " f"on interpreter shutdown "
f"stage, signal unsubsription is disabled", f"stage, skipping signal handlers removal",
ResourceWarning, ResourceWarning,
source=self) source=self)
self._signal_handlers.clear() self._signal_handlers.clear()

17
Lib/test/test_asyncio/test_unix_events.py
View file

@ -229,6 +229,23 @@ def test_close(self, m_signal):
self.assertEqual(len(self.loop._signal_handlers), 0) self.assertEqual(len(self.loop._signal_handlers), 0)
m_signal.set_wakeup_fd.assert_called_once_with(-1) m_signal.set_wakeup_fd.assert_called_once_with(-1)
@mock.patch('asyncio.unix_events.sys')
@mock.patch('asyncio.unix_events.signal')
def test_close_on_finalizing(self, m_signal, m_sys):
m_signal.NSIG = signal.NSIG
self.loop.add_signal_handler(signal.SIGHUP, lambda: True)
self.assertEqual(len(self.loop._signal_handlers), 1)
m_sys.is_finalizing.return_value = True
m_signal.signal.reset_mock()
with self.assertWarnsRegex(ResourceWarning,
"skipping signal handlers removal"):
self.loop.close()
self.assertEqual(len(self.loop._signal_handlers), 0)
self.assertFalse(m_signal.signal.called)
@unittest.skipUnless(hasattr(socket, 'AF_UNIX'), @unittest.skipUnless(hasattr(socket, 'AF_UNIX'),
'UNIX Sockets are not supported') 'UNIX Sockets are not supported')