Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-31 04:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-105235: Prevent reading outside buffer during mmap.find() (#105252)

Browse source 
* Add a special case for s[-m:] == p in _PyBytes_Find

* Add tests for _PyBytes_Find

* Make sure that start <= end in mmap.find
This commit is contained in:
Dennis Sweeney 2023-07-12 22:50:45 -04:00 • committed by GitHub
parent 2d43beec22
commit ab86426a34
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 161 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Objects/bytesobject.c
View file

@ -1272,8 +1272,25 @@ _PyBytes_Find(const char *haystack, Py_ssize_t len_haystack,
const char *needle, Py_ssize_t len_needle,
Py_ssize_t offset)
{
return stringlib_find(haystack, len_haystack,
needle, len_needle, offset);
assert(len_haystack >= 0);
assert(len_needle >= 0);
// Extra checks because stringlib_find accesses haystack[len_haystack].
if (len_needle == 0) {
return offset;
}
if (len_needle > len_haystack) {
return -1;
}
assert(len_haystack >= 1);
Py_ssize_t res = stringlib_find(haystack, len_haystack - 1,
needle, len_needle, offset);
if (res == -1) {
Py_ssize_t last_align = len_haystack - len_needle;
if (memcmp(haystack + last_align, needle, len_needle) == 0) {
return offset + last_align;
}
}
return res;
}
Py_ssize_t