Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-19 16:03:42 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-140000: Traverse name attribute for TypeVar, TypeVarTuple, TypeAliasType, ParamSpec (#140016)

Browse source
This commit is contained in:
Mikhail Efimov 2025-10-13 23:10:39 +03:00 • committed by GitHub
parent c46265d94a
commit be60e4b4f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Misc/NEWS.d/next/Core_and_Builtins/2025-10-13-17-56-23.gh-issue-140000.tLhn3e.rst Normal file
View file

@ -0,0 +1,4 @@
Fix potential memory leak when a reference cycle exists between an instance
of :class:`typing.TypeAliasType`, :class:`typing.TypeVar`,
:class:`typing.ParamSpec`, or :class:`typing.TypeVarTuple` and its
``__name__`` attribute. Patch by Mikhail Efimov.

16
Objects/typevarobject.c
View file

@ -472,7 +472,7 @@ typevar_dealloc(PyObject *self)
_PyObject_GC_UNTRACK(self); _PyObject_GC_UNTRACK(self);
Py_DECREF(tv->name); Py_XDECREF(tv->name);
Py_XDECREF(tv->bound); Py_XDECREF(tv->bound);
Py_XDECREF(tv->evaluate_bound); Py_XDECREF(tv->evaluate_bound);
Py_XDECREF(tv->constraints); Py_XDECREF(tv->constraints);
@ -491,6 +491,7 @@ typevar_traverse(PyObject *self, visitproc visit, void *arg)
{ {
Py_VISIT(Py_TYPE(self)); Py_VISIT(Py_TYPE(self));
typevarobject *tv = typevarobject_CAST(self); typevarobject *tv = typevarobject_CAST(self);
Py_VISIT(tv->name);
Py_VISIT(tv->bound); Py_VISIT(tv->bound);
Py_VISIT(tv->evaluate_bound); Py_VISIT(tv->evaluate_bound);
Py_VISIT(tv->constraints); Py_VISIT(tv->constraints);
@ -505,6 +506,7 @@ static int
typevar_clear(PyObject *op) typevar_clear(PyObject *op)
{ {
typevarobject *self = typevarobject_CAST(op); typevarobject *self = typevarobject_CAST(op);
Py_CLEAR(self->name);
Py_CLEAR(self->bound); Py_CLEAR(self->bound);
Py_CLEAR(self->evaluate_bound); Py_CLEAR(self->evaluate_bound);
Py_CLEAR(self->constraints); Py_CLEAR(self->constraints);
@ -1171,7 +1173,7 @@ paramspec_dealloc(PyObject *self)
_PyObject_GC_UNTRACK(self); _PyObject_GC_UNTRACK(self);
Py_DECREF(ps->name); Py_XDECREF(ps->name);
Py_XDECREF(ps->bound); Py_XDECREF(ps->bound);
Py_XDECREF(ps->default_value); Py_XDECREF(ps->default_value);
Py_XDECREF(ps->evaluate_default); Py_XDECREF(ps->evaluate_default);
@ -1187,6 +1189,7 @@ paramspec_traverse(PyObject *self, visitproc visit, void *arg)
{ {
Py_VISIT(Py_TYPE(self)); Py_VISIT(Py_TYPE(self));
paramspecobject *ps = paramspecobject_CAST(self); paramspecobject *ps = paramspecobject_CAST(self);
Py_VISIT(ps->name);
Py_VISIT(ps->bound); Py_VISIT(ps->bound);
Py_VISIT(ps->default_value); Py_VISIT(ps->default_value);
Py_VISIT(ps->evaluate_default); Py_VISIT(ps->evaluate_default);
@ -1198,6 +1201,7 @@ static int
paramspec_clear(PyObject *op) paramspec_clear(PyObject *op)
{ {
paramspecobject *self = paramspecobject_CAST(op); paramspecobject *self = paramspecobject_CAST(op);
Py_CLEAR(self->name);
Py_CLEAR(self->bound); Py_CLEAR(self->bound);
Py_CLEAR(self->default_value); Py_CLEAR(self->default_value);
Py_CLEAR(self->evaluate_default); Py_CLEAR(self->evaluate_default);
@ -1519,7 +1523,7 @@ typevartuple_dealloc(PyObject *self)
_PyObject_GC_UNTRACK(self); _PyObject_GC_UNTRACK(self);
typevartupleobject *tvt = typevartupleobject_CAST(self); typevartupleobject *tvt = typevartupleobject_CAST(self);
Py_DECREF(tvt->name); Py_XDECREF(tvt->name);
Py_XDECREF(tvt->default_value); Py_XDECREF(tvt->default_value);
Py_XDECREF(tvt->evaluate_default); Py_XDECREF(tvt->evaluate_default);
PyObject_ClearManagedDict(self); PyObject_ClearManagedDict(self);
@ -1683,6 +1687,7 @@ typevartuple_traverse(PyObject *self, visitproc visit, void *arg)
{ {
Py_VISIT(Py_TYPE(self)); Py_VISIT(Py_TYPE(self));
typevartupleobject *tvt = typevartupleobject_CAST(self); typevartupleobject *tvt = typevartupleobject_CAST(self);
Py_VISIT(tvt->name);
Py_VISIT(tvt->default_value); Py_VISIT(tvt->default_value);
Py_VISIT(tvt->evaluate_default); Py_VISIT(tvt->evaluate_default);
PyObject_VisitManagedDict(self, visit, arg); PyObject_VisitManagedDict(self, visit, arg);
@ -1693,6 +1698,7 @@ static int
typevartuple_clear(PyObject *self) typevartuple_clear(PyObject *self)
{ {
typevartupleobject *tvt = typevartupleobject_CAST(self); typevartupleobject *tvt = typevartupleobject_CAST(self);
Py_CLEAR(tvt->name);
Py_CLEAR(tvt->default_value); Py_CLEAR(tvt->default_value);
Py_CLEAR(tvt->evaluate_default); Py_CLEAR(tvt->evaluate_default);
PyObject_ClearManagedDict(self); PyObject_ClearManagedDict(self);
@ -1851,7 +1857,7 @@ typealias_dealloc(PyObject *self)
PyTypeObject *tp = Py_TYPE(self); PyTypeObject *tp = Py_TYPE(self);
_PyObject_GC_UNTRACK(self); _PyObject_GC_UNTRACK(self);
typealiasobject *ta = typealiasobject_CAST(self); typealiasobject *ta = typealiasobject_CAST(self);
Py_DECREF(ta->name); Py_XDECREF(ta->name);
Py_XDECREF(ta->type_params); Py_XDECREF(ta->type_params);
Py_XDECREF(ta->compute_value); Py_XDECREF(ta->compute_value);
Py_XDECREF(ta->value); Py_XDECREF(ta->value);
@ -2032,6 +2038,7 @@ static int
typealias_traverse(PyObject *op, visitproc visit, void *arg) typealias_traverse(PyObject *op, visitproc visit, void *arg)
{ {
typealiasobject *self = typealiasobject_CAST(op); typealiasobject *self = typealiasobject_CAST(op);
Py_VISIT(self->name);
Py_VISIT(self->type_params); Py_VISIT(self->type_params);
Py_VISIT(self->compute_value); Py_VISIT(self->compute_value);
Py_VISIT(self->value); Py_VISIT(self->value);
@ -2043,6 +2050,7 @@ static int
typealias_clear(PyObject *op) typealias_clear(PyObject *op)
{ {
typealiasobject *self = typealiasobject_CAST(op); typealiasobject *self = typealiasobject_CAST(op);
Py_CLEAR(self->name);
Py_CLEAR(self->type_params); Py_CLEAR(self->type_params);
Py_CLEAR(self->compute_value); Py_CLEAR(self->compute_value);
Py_CLEAR(self->value); Py_CLEAR(self->value);